1262590 - [e10s] AppProcessChecker.cpp have DEUBG typo preventing DEBUG messages

Status: RESOLVED FIXED

(Core :: IPC, defect, P4)

Description

[Haik Aftandilian [:haik]]

This is a super-minor debug-build-only logging bug. TabParent.cpp and AppProcessChecker.cpp have the following typo preventing their LOG messages from printing.

  39 #if DEUBG
  40   #define LOG(args...) printf_stderr(args)
  41 #else
  42   #define LOG(...)
  43 #endif

"DEUBG" should be "DEBUG".

Making this a separate bug just in case code in LOG() statements in these files turns out to be broken and needs additional work.

Comment 1

[Haik Aftandilian [:haik]]

Attachment: Patch to correct DEUBG typo

Fixed the typo. Had to use __VA_ARGS__ in order to build on Windows.

Comment 2

[Mike Conley (:mconley) (:⚙️)]

Comment on attachment 8740183 [details] [diff] [review]
Patch to correct DEUBG typo

Review of attachment 8740183 [details] [diff] [review]:
-----------------------------------------------------------------

*facepalm*

Thanks Haik. :)

Comment 3

[Haik Aftandilian [:haik]]

Attachment: Updated to account for 1260876 removing offending code from TabParent.cpp

https://treeherder.mozilla.org/#/jobs?repo=try&revision=215c2819eae0

Comment 4

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/70d14e1c238b

Comment 5

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/70d14e1c238b