Closed Bug 1262590 Opened 3 years ago Closed 3 years ago

[e10s] AppProcessChecker.cpp have DEUBG typo preventing DEBUG messages

Categories

(Core :: IPC, defect, P4, trivial)

48 Branch
defect

Tracking

()

RESOLVED FIXED
mozilla48
Tracking Status
e10s + ---
firefox48 --- fixed

People

(Reporter: haik, Assigned: haik)

References

Details

(Whiteboard: btpp-active)

Attachments

(1 file, 1 obsolete file)

This is a super-minor debug-build-only logging bug. TabParent.cpp and AppProcessChecker.cpp have the following typo preventing their LOG messages from printing.

  39 #if DEUBG
  40   #define LOG(args...) printf_stderr(args)
  41 #else
  42   #define LOG(...)
  43 #endif

"DEUBG" should be "DEBUG".

Making this a separate bug just in case code in LOG() statements in these files turns out to be broken and needs additional work.
Assignee: nobody → haftandilian
tracking-e10s: --- → +
Priority: -- → P4
Whiteboard: btpp-active
Attached patch Patch to correct DEUBG typo (obsolete) — Splinter Review
Fixed the typo. Had to use __VA_ARGS__ in order to build on Windows.
Attachment #8740183 - Flags: review?(mconley)
Comment on attachment 8740183 [details] [diff] [review]
Patch to correct DEUBG typo

Review of attachment 8740183 [details] [diff] [review]:
-----------------------------------------------------------------

*facepalm*

Thanks Haik. :)
Attachment #8740183 - Flags: review?(mconley) → review+
Summary: [e10s] TabParent.cpp and AppProcessChecker.cpp have DEUBG typo preventing DEBUG messages → [e10s] AppProcessChecker.cpp have DEUBG typo preventing DEBUG messages
See Also: → 1260876
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/70d14e1c238b
Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla48
You need to log in before you can comment on or make changes to this bug.