Closed
Bug 1262618
Opened 5 years ago
Closed 5 years ago
Fix an unchained promise and a couple of non-promise returns in the push service
Categories
(Core :: DOM: Push Notifications, defect)
Core
DOM: Push Notifications
Tracking
()
RESOLVED
FIXED
mozilla48
Tracking | Status | |
---|---|---|
firefox48 | --- | fixed |
People
(Reporter: markh, Assigned: markh)
Details
Attachments
(1 file)
2.53 KB,
patch
|
wchen
:
review+
|
Details | Diff | Splinter Review |
There seem to be a couple of edge-cases that aren't handled quite correctly in the push service: * when handling the 'idle-daily' notification, we call a function that returns a promise, but ignore the result. We should .catch and log to ensure the error is seen and to prevent "unhandled promise rejection" warnings. * _changeServerURL is expected to return a promise, but will not do so if an unknown event is passed. * _stopService() is expected to return a promise, but will not do so if the service is not initialized. These seem minor and probably unlikely to be hit, but it seems to make sense to fix them. William, what do you think?
Attachment #8738750 -
Flags: review?(wchen)
Comment 1•5 years ago
|
||
Comment on attachment 8738750 [details] [diff] [review] 0001-Bug-XXXXXXX-Fix-an-unchained-promise-and-a-couple-of.patch Review of attachment 8738750 [details] [diff] [review]: ----------------------------------------------------------------- looks good.
Attachment #8738750 -
Flags: review?(wchen) → review+
Assignee | ||
Updated•5 years ago
|
Assignee: nobody → markh
Comment 3•5 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/04e4fbe0584e
Status: NEW → RESOLVED
Closed: 5 years ago
status-firefox48:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla48
You need to log in
before you can comment on or make changes to this bug.
Description
•