1262624 - Upstream service workers wpt tests

Status: RESOLVED FIXED

(Core :: DOM: Service Workers, defect)

Description

[Ben Kelly [:bkelly, not reviewing]]

We currently have our SW wpt tests in a mozilla specific directory.  We need to upstream them so we can collaborate better with other browser vendors.  I have already run this past folks at google and they are good with it.  They will issue PRs if they have any problems with our current tests.

Comment 1

[Ben Kelly [:bkelly, not reviewing]]

Attachment: Move service worker wpt tests out of mozilla dir so they will be upstreamed. r=jgraham

I moved the tests and meta files and then updated the manifest.

https://treeherder.mozilla.org/#/jobs?repo=try&revision=6119291d5f75

Comment 2

[Ben Kelly [:bkelly, not reviewing]]

Attachment: Move service worker wpt tests out of mozilla dir so they will be upstreamed. r=jgraham

Updated to remove bogus manifest changes.

https://treeherder.mozilla.org/#/jobs?repo=try&revision=9fa5a2dcd5c0

Comment 3

[James Graham [:jgraham]]

Comment on attachment 8738795 [details] [diff] [review]
Move service worker wpt tests out of mozilla dir so they will be upstreamed. r=jgraham

Review of attachment 8738795 [details] [diff] [review]:
-----------------------------------------------------------------

Manifest changes look OK (without inspecting every line in detail; did you generate them with |mach web-platform-tests --manifest-update|?); but the actual file moves are missing from this attachment.

Comment 4

[Ben Kelly [:bkelly, not reviewing]]

(In reply to James Graham [:jgraham] from comment #3)
> Manifest changes look OK (without inspecting every line in detail; did you
> generate them with |mach web-platform-tests --manifest-update|?); but the
> actual file moves are missing from this attachment.

I used manifest-update and then removed all the bogus reftest changes.

The moved test files are in the patch.  Splinter review tool just doesn't show them because they are hg renames.

Comment 5

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/26e409f43a2e

Comment 6

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/26e409f43a2e