Upstream service workers wpt tests

RESOLVED FIXED in Firefox 48

Status

()

Core
DOM: Service Workers
RESOLVED FIXED
2 years ago
2 years ago

People

(Reporter: bkelly, Assigned: bkelly)

Tracking

Trunk
mozilla48
Points:
---

Firefox Tracking Flags

(firefox48 fixed)

Details

Attachments

(1 attachment, 1 obsolete attachment)

(Assignee)

Description

2 years ago
We currently have our SW wpt tests in a mozilla specific directory.  We need to upstream them so we can collaborate better with other browser vendors.  I have already run this past folks at google and they are good with it.  They will issue PRs if they have any problems with our current tests.
(Assignee)

Comment 1

2 years ago
Created attachment 8738759 [details] [diff] [review]
Move service worker wpt tests out of mozilla dir so they will be upstreamed. r=jgraham

I moved the tests and meta files and then updated the manifest.

https://treeherder.mozilla.org/#/jobs?repo=try&revision=6119291d5f75
Attachment #8738759 - Flags: review?(james)
(Assignee)

Comment 2

2 years ago
Created attachment 8738795 [details] [diff] [review]
Move service worker wpt tests out of mozilla dir so they will be upstreamed. r=jgraham

Updated to remove bogus manifest changes.

https://treeherder.mozilla.org/#/jobs?repo=try&revision=9fa5a2dcd5c0
Attachment #8738759 - Attachment is obsolete: true
Attachment #8738759 - Flags: review?(james)
Attachment #8738795 - Flags: review?(james)
Comment on attachment 8738795 [details] [diff] [review]
Move service worker wpt tests out of mozilla dir so they will be upstreamed. r=jgraham

Review of attachment 8738795 [details] [diff] [review]:
-----------------------------------------------------------------

Manifest changes look OK (without inspecting every line in detail; did you generate them with |mach web-platform-tests --manifest-update|?); but the actual file moves are missing from this attachment.
Attachment #8738795 - Flags: review?(james) → review+
(Assignee)

Comment 4

2 years ago
(In reply to James Graham [:jgraham] from comment #3)
> Manifest changes look OK (without inspecting every line in detail; did you
> generate them with |mach web-platform-tests --manifest-update|?); but the
> actual file moves are missing from this attachment.

I used manifest-update and then removed all the bogus reftest changes.

The moved test files are in the patch.  Splinter review tool just doesn't show them because they are hg renames.

Comment 6

2 years ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/26e409f43a2e
Status: ASSIGNED → RESOLVED
Last Resolved: 2 years ago
status-firefox48: affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla48
You need to log in before you can comment on or make changes to this bug.