1262676 - Fix sentry error logging

Status: NEW

(bugzilla.mozilla.org :: General, defect)

Description

[Dylan Hardison [:dylan] (he/him)]

$SIG{__DIE__} is evil. We use it for sentry. It gets call for every error, even errors that are eventually caught. 

I think we should catch top level errors differently when running under apache.

Comment 1

[Dylan Hardison [:dylan] (he/him)]

Attachment: 1262676_1.patch

Comment 2

[David Lawrence [:dkl]]

Comment on attachment 8738851 [details] [diff] [review]
1262676_1.patch

Review of attachment 8738851 [details] [diff] [review]:
-----------------------------------------------------------------

for both mod_cgi and mod_perl, I no longer get header and footer for errors displayed to the browser. Only the error message in plain text on white background.

::: mod_perl.pl
@@ +159,4 @@
>          : $result;
>  }
>  
> +# this function is called when a cgi throws an uncaughter exception.

"uncaught"

@@ +159,5 @@
>          : $result;
>  }
>  
> +# this function is called when a cgi throws an uncaughter exception.
> +# it ignores exit(), conveniently, so we don't have to worry about cechking for that here.

"checking"

Comment 3

[Dylan Hardison [:dylan] (he/him)]

curious about that. I'll have a revision up shortly.

Comment 4

[Dylan Hardison [:dylan] (he/him)]

I think I figured this out. You need to hack bz-dev-manager to NOT patch in $::SIG{__DIE__} in Bugzilla.pm.

Comment 5

[Jonathan Claudius [:claudijd] (use NEEDINFO)]

No updates on this in the past year.  Just checking in as this was listed as a potential fix to bug 1324496.

Comment 6

[Dylan Hardison [:dylan] (he/him)]

I know someone that can work on this. :-)