Status

()

bugzilla.mozilla.org
General
2 years ago
a year ago

People

(Reporter: dylan, Assigned: dylan)

Tracking

(Blocks: 1 bug)

Production

Details

Attachments

(1 attachment)

(Assignee)

Description

2 years ago
$SIG{__DIE__} is evil. We use it for sentry. It gets call for every error, even errors that are eventually caught. 

I think we should catch top level errors differently when running under apache.
(Assignee)

Comment 1

2 years ago
Created attachment 8738851 [details] [diff] [review]
1262676_1.patch
Attachment #8738851 - Flags: review?(dkl)
Comment on attachment 8738851 [details] [diff] [review]
1262676_1.patch

Review of attachment 8738851 [details] [diff] [review]:
-----------------------------------------------------------------

for both mod_cgi and mod_perl, I no longer get header and footer for errors displayed to the browser. Only the error message in plain text on white background.

::: mod_perl.pl
@@ +159,4 @@
>          : $result;
>  }
>  
> +# this function is called when a cgi throws an uncaughter exception.

"uncaught"

@@ +159,5 @@
>          : $result;
>  }
>  
> +# this function is called when a cgi throws an uncaughter exception.
> +# it ignores exit(), conveniently, so we don't have to worry about cechking for that here.

"checking"
Attachment #8738851 - Flags: review?(dkl) → review-
(Assignee)

Comment 3

2 years ago
curious about that. I'll have a revision up shortly.
(Assignee)

Comment 4

2 years ago
I think I figured this out. You need to hack bz-dev-manager to NOT patch in $::SIG{__DIE__} in Bugzilla.pm.
No updates on this in the past year.  Just checking in as this was listed as a potential fix to bug 1324496.
Flags: needinfo?(dylan)
(Assignee)

Comment 6

a year ago
I know someone that can work on this. :-)
Flags: needinfo?(dylan)
You need to log in before you can comment on or make changes to this bug.