Add HTML5 <!DOCTYPE> declaration to MathML tests

RESOLVED FIXED in Firefox 48

Status

()

defect
--
trivial
RESOLVED FIXED
3 years ago
3 years ago

People

(Reporter: fredw, Assigned: aeriklawson, Mentored)

Tracking

(Depends on 1 bug)

Trunk
mozilla48
Points:
---

Firefox Tracking Flags

(firefox48 fixed)

Details

(Whiteboard: [lang=html][good first bug])

Attachments

(1 attachment, 1 obsolete attachment)

(Reporter)

Description

3 years ago
While importing some Mozilla MathML tests into WebKit, a reviewer asked me to use the HTML5 <!DOCTYPE> declaration for all new tests. It seems that we miss it for some of our tests like mpadded, movablelimits etc
(Assignee)

Comment 1

3 years ago
Hey, I'm new here. Can I take this one?
(Reporter)

Comment 2

3 years ago
Hi Andrew, welcome. Sure, I'm assigning you the bug. The tests to changes are located there:

http://hg.mozilla.org/mozilla-central/file/tip/layout/reftests/mathml

If you need any help, do not hesitate to ask. Thanks.
Assignee: nobody → aeriklawson
(Reporter)

Comment 4

3 years ago
Thanks for the patch. Note that it is incorrect to do that for XHTML tests, since they follow a different XML syntax. Unless one of this test explicitly check support for MathML in XHTML, I guess it is safe to convert them to the HTML5 syntax (them you must remove namespace prefix, can remove xmlns attributes etc). However, that can be done in a follow-up bug.

When you feel your patch is ready, follow the instructions there to get your patch reviewed: https://developer.mozilla.org/en-US/docs/Mozilla/Developer_guide/How_to_Submit_a_Patch#Getting_the_patch_reviewed
(Assignee)

Updated

3 years ago
Attachment #8740764 - Attachment is obsolete: true
(Assignee)

Comment 6

3 years ago
Okay, I just left out the declaration from the XHTML tests in this new one.
(Assignee)

Updated

3 years ago
Attachment #8741430 - Flags: review?(fred.wang)
(Reporter)

Comment 7

3 years ago
Comment on attachment 8741430 [details] [diff] [review]
Add '<!DOCTYPE html>' declaration to all MathML HTML tests (excludes XHTML)

Review of attachment 8741430 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks, that looks good to me.
Attachment #8741430 - Flags: review?(fred.wang) → review+
(Assignee)

Comment 8

3 years ago
Cool. Does this need to go to the try server now? I don't believe I have permissions for that.
(Assignee)

Updated

3 years ago
Keywords: checkin-needed

Comment 11

3 years ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/1a343fc53ce5
Status: NEW → RESOLVED
Last Resolved: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla48
You need to log in before you can comment on or make changes to this bug.