Closed
Bug 1262744
Opened 8 years ago
Closed 8 years ago
Add HTML5 <!DOCTYPE> declaration to MathML tests
Categories
(Core :: MathML, defect)
Core
MathML
Tracking
()
RESOLVED
FIXED
mozilla48
Tracking | Status | |
---|---|---|
firefox48 | --- | fixed |
People
(Reporter: fredw, Assigned: aeriklawson, Mentored)
References
(Depends on 1 open bug)
Details
(Whiteboard: [lang=html][good first bug])
Attachments
(1 file, 1 obsolete file)
164.23 KB,
patch
|
fredw
:
review+
|
Details | Diff | Splinter Review |
While importing some Mozilla MathML tests into WebKit, a reviewer asked me to use the HTML5 <!DOCTYPE> declaration for all new tests. It seems that we miss it for some of our tests like mpadded, movablelimits etc
Assignee | ||
Comment 1•8 years ago
|
||
Hey, I'm new here. Can I take this one?
Reporter | ||
Comment 2•8 years ago
|
||
Hi Andrew, welcome. Sure, I'm assigning you the bug. The tests to changes are located there: http://hg.mozilla.org/mozilla-central/file/tip/layout/reftests/mathml If you need any help, do not hesitate to ask. Thanks.
Assignee: nobody → aeriklawson
Assignee | ||
Comment 3•8 years ago
|
||
Reporter | ||
Comment 4•8 years ago
|
||
Thanks for the patch. Note that it is incorrect to do that for XHTML tests, since they follow a different XML syntax. Unless one of this test explicitly check support for MathML in XHTML, I guess it is safe to convert them to the HTML5 syntax (them you must remove namespace prefix, can remove xmlns attributes etc). However, that can be done in a follow-up bug. When you feel your patch is ready, follow the instructions there to get your patch reviewed: https://developer.mozilla.org/en-US/docs/Mozilla/Developer_guide/How_to_Submit_a_Patch#Getting_the_patch_reviewed
Assignee | ||
Comment 5•8 years ago
|
||
Assignee | ||
Updated•8 years ago
|
Attachment #8740764 -
Attachment is obsolete: true
Assignee | ||
Comment 6•8 years ago
|
||
Okay, I just left out the declaration from the XHTML tests in this new one.
Assignee | ||
Updated•8 years ago
|
Attachment #8741430 -
Flags: review?(fred.wang)
Reporter | ||
Comment 7•8 years ago
|
||
Comment on attachment 8741430 [details] [diff] [review] Add '<!DOCTYPE html>' declaration to all MathML HTML tests (excludes XHTML) Review of attachment 8741430 [details] [diff] [review]: ----------------------------------------------------------------- Thanks, that looks good to me.
Attachment #8741430 -
Flags: review?(fred.wang) → review+
Assignee | ||
Comment 8•8 years ago
|
||
Cool. Does this need to go to the try server now? I don't believe I have permissions for that.
Reporter | ||
Comment 9•8 years ago
|
||
I submitted https://treeherder.mozilla.org/#/jobs?repo=try&revision=8d267b397f02 Please check the result and set checkin-needed if everything is ok. (If you don't have editbugs privilege, see https://developer.mozilla.org/en-US/docs/Mozilla/Bugzilla/What_to_do_and_what_not_to_do_in_Bugzilla#Getting.2FUpgrading_Bugzilla_privileges)
Assignee | ||
Updated•8 years ago
|
Keywords: checkin-needed
Comment 10•8 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/1a343fc53ce5
Keywords: checkin-needed
Comment 11•8 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/1a343fc53ce5
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla48
You need to log in
before you can comment on or make changes to this bug.
Description
•