Closed Bug 1262744 Opened 5 years ago Closed 5 years ago

Add HTML5 <!DOCTYPE> declaration to MathML tests


(Core :: MathML, defect)

Not set



Tracking Status
firefox48 --- fixed


(Reporter: fredw, Assigned: aeriklawson, Mentored)


(Depends on 1 open bug)


(Whiteboard: [lang=html][good first bug])


(1 file, 1 obsolete file)

While importing some Mozilla MathML tests into WebKit, a reviewer asked me to use the HTML5 <!DOCTYPE> declaration for all new tests. It seems that we miss it for some of our tests like mpadded, movablelimits etc
Hey, I'm new here. Can I take this one?
Hi Andrew, welcome. Sure, I'm assigning you the bug. The tests to changes are located there:

If you need any help, do not hesitate to ask. Thanks.
Assignee: nobody → aeriklawson
Thanks for the patch. Note that it is incorrect to do that for XHTML tests, since they follow a different XML syntax. Unless one of this test explicitly check support for MathML in XHTML, I guess it is safe to convert them to the HTML5 syntax (them you must remove namespace prefix, can remove xmlns attributes etc). However, that can be done in a follow-up bug.

When you feel your patch is ready, follow the instructions there to get your patch reviewed:
Attachment #8740764 - Attachment is obsolete: true
Okay, I just left out the declaration from the XHTML tests in this new one.
Attachment #8741430 - Flags: review?(
Comment on attachment 8741430 [details] [diff] [review]
Add '<!DOCTYPE html>' declaration to all MathML HTML tests (excludes XHTML)

Review of attachment 8741430 [details] [diff] [review]:

Thanks, that looks good to me.
Attachment #8741430 - Flags: review?( → review+
Cool. Does this need to go to the try server now? I don't believe I have permissions for that.
Keywords: checkin-needed
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla48
You need to log in before you can comment on or make changes to this bug.