While importing some Mozilla MathML tests into WebKit, a reviewer asked me to use the HTML5 <!DOCTYPE> declaration for all new tests. It seems that we miss it for some of our tests like mpadded, movablelimits etc
Hey, I'm new here. Can I take this one?
Hi Andrew, welcome. Sure, I'm assigning you the bug. The tests to changes are located there: http://hg.mozilla.org/mozilla-central/file/tip/layout/reftests/mathml If you need any help, do not hesitate to ask. Thanks.
Assignee: nobody → aeriklawson
Created attachment 8740764 [details] [diff] [review] Add '<!DOCTYPE html>' declaration to MathML test files
Thanks for the patch. Note that it is incorrect to do that for XHTML tests, since they follow a different XML syntax. Unless one of this test explicitly check support for MathML in XHTML, I guess it is safe to convert them to the HTML5 syntax (them you must remove namespace prefix, can remove xmlns attributes etc). However, that can be done in a follow-up bug. When you feel your patch is ready, follow the instructions there to get your patch reviewed: https://developer.mozilla.org/en-US/docs/Mozilla/Developer_guide/How_to_Submit_a_Patch#Getting_the_patch_reviewed
Created attachment 8741430 [details] [diff] [review] Add '<!DOCTYPE html>' declaration to all MathML HTML tests (excludes XHTML)
Okay, I just left out the declaration from the XHTML tests in this new one.
Comment on attachment 8741430 [details] [diff] [review] Add '<!DOCTYPE html>' declaration to all MathML HTML tests (excludes XHTML) Review of attachment 8741430 [details] [diff] [review]: ----------------------------------------------------------------- Thanks, that looks good to me.
Attachment #8741430 - Flags: review?(fred.wang) → review+
Cool. Does this need to go to the try server now? I don't believe I have permissions for that.
I submitted https://treeherder.mozilla.org/#/jobs?repo=try&revision=8d267b397f02 Please check the result and set checkin-needed if everything is ok. (If you don't have editbugs privilege, see https://developer.mozilla.org/en-US/docs/Mozilla/Bugzilla/What_to_do_and_what_not_to_do_in_Bugzilla#Getting.2FUpgrading_Bugzilla_privileges)
Status: NEW → RESOLVED
Last Resolved: 2 years ago
status-firefox48: affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla48
You need to log in before you can comment on or make changes to this bug.