Rewrite signature summaries as SuperSearch derivatives

NEW
Unassigned

Status

Socorro
Webapp
2 years ago
2 years ago

People

(Reporter: peterbe, Unassigned)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

(Reporter)

Description

2 years ago
When we built the Signature Report we re-wrote the signature summaries as real-time queries based on SuperSearch (and some other bits). Instead of being something done in an implementation class, these are plain python functions inside webapp-django/crashstats/signature/views.py 

As an example: https://github.com/mozilla/socorro/blob/0537266f5cf69171de83ae3e02decd28a4c9a0c2/webapp-django/crashstats/signature/views.py#L280

What we ought to do is move these into "model classes". That way, the old report list will be able to use this instead of having to do a SQL query. Basically, instead of:

  # in crashstats/views.py
  def report_list(request):
      ...
      from crashstats.crashstats.models import SignatureSummary
      stuff = SignatureSummary().get(report_type='comments', signature=signature, ...)

it would be:

  # in crashstats/views.py
  def report_list(request):
      ...
      from crashstats.signature.models import SignatureSummary
      stuff = SignatureSummary().get(report_type='comments', signature=signature, ...)

      
Transparent change. The Web API endpoint would be unaffected, from the outside. Both the old report list and the new signature report would be unaffected. 

And lastly, we'd be able to delete the signature summary crontabber apps and eventually, when things have been tested and matured, we can delete the stored procedures and the signature summary tables.
You need to log in before you can comment on or make changes to this bug.