126285 - <wizard/> : returning false on onpageadvanced is not honored if the request is from a overlay wizardpage

Status: RESOLVED INVALID

(Core :: XUL, defect)

Description

[racham]

If we include an overlay which contains a wizardpage, and do a data validation
of that page and return false in case of insufficient data, the <wizard/> should
remain on the same overlay page. Instead it simply goes to the next
<wizardpage/> if there is one. Where as regular wizardpages do the right thing
by not advancing to the next page inthe flow incase onpageadvanced handler
returns false.

Comment 1

[racham]

This bug blocks 2 bugscpe bugs :

1. http://bugscape.netscape.com/show_bug.cgi?id=1282
2. http://bugscape.netscape.com/show_bug.cgi?id=11730

Comment 2

[Peter Trudelle]

Nav Triage Team:  marking nsbeta1+

Comment 3

[Peter Trudelle]

Mass move of nsbeta1+ bugs that didn't have a valid MachV milestone to mozilla1.0.

Comment 4

[Blake Ross]

Can you please explain this further and point at sample code?  The bug is that
returning false from onpageadvanced still advanced to the next wizard page _only
when the wizardpage is overlayed_?

Comment 5

[Blake Ross]

I notice in the code in http://bugscape.netscape.com/show_bug.cgi?id=11730 that
you're not returning a value in any of the wizardpage event handlers.  You have
to return a value for it to be recognized.  This is properly being done in
AccountWizard.xul in mail.  Maybe that's the only problem?

Comment 6

[racham]

Blake you are right !

I had to do onpageadvanced="return handler();". Simply putting handler in there
like regular dialogs will not work here. Thanks to Blake & Hewitt.

Marking this invalid.