Closed Bug 1262942 Opened 8 years ago Closed 8 years ago

6,300 instances of "NS_ENSURE_TRUE(!mDefaultSourceURL.IsEmpty()) failed" emitted from dom/base/ResponsiveImageSelector.cpp during linux64 debug testing

Categories

(Core :: DOM: Core & HTML, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla48
Tracking Status
firefox48 --- fixed

People

(Reporter: erahm, Assigned: edgar)

References

(Blocks 1 open bug)

Details

(Whiteboard: [tw-dom] btpp-active)

Attachments

(1 file)

> 2408 [NNNNN] WARNING: NS_ENSURE_TRUE(!mDefaultSourceURL.IsEmpty()) failed: file dom/base/ResponsiveImageSelector.cpp, line 280

This warning [1] shows up in the following test suites:

> mozilla-central_ubuntu64_vm-debug_test-web-platform-tests-3-bm116-tests1-linux64-build8.txt:890
> mozilla-central_ubuntu64_vm-debug_test-web-platform-tests-e10s-3-bm121-tests1-linux64-build5.txt:874
> mozilla-central_ubuntu64_vm-debug_test-mochitest-e10s-8-bm131-tests1-linux64-build0.txt:99
> mozilla-central_ubuntu64_vm-debug_test-mochitest-e10s-8-bm118-tests1-linux64-build3.txt:99
> mozilla-central_ubuntu64_vm-debug_test-mochitest-8-bm54-tests1-linux64-build0.txt:99
> mozilla-central_ubuntu64_vm-debug_test-reftest-e10s-2-bm118-tests1-linux64-build10.txt:74
> mozilla-central_ubuntu64_vm-debug_test-reftest-3-bm131-tests1-linux64-build5.txt:62
> mozilla-central_ubuntu64_vm-debug_test-mochitest-e10s-5-bm68-tests1-linux64-build4.txt:27
> mozilla-central_ubuntu64_vm-debug_test-mochitest-5-bm122-tests1-linux64-build8.txt:27
> mozilla-central_ubuntu64_vm-debug_test-mochitest-e10s-7-bm123-tests1-linux64-build6.txt:20
> mozilla-central_ubuntu64_vm-debug_test-mochitest-e10s-4-bm131-tests1-linux64-build3.txt:20
> mozilla-central_ubuntu64_vm-debug_test-mochitest-7-bm115-tests1-linux64-build4.txt:20
> mozilla-central_ubuntu64_vm-debug_test-mochitest-4-bm122-tests1-linux64-build3.txt:20
> mozilla-central_ubuntu64_vm-debug_test-web-platform-tests-5-bm54-tests1-linux64-build2.txt:17
> mozilla-central_ubuntu64_vm-debug_test-web-platform-tests-e10s-5-bm68-tests1-linux64-build4.txt:16
> mozilla-central_ubuntu64_vm-debug_test-mochitest-other-bm131-tests1-linux64-build4.txt:16
> mozilla-central_ubuntu64_vm-debug_test-reftest-4-bm52-tests1-linux64-build7.txt:12
> mozilla-central_ubuntu64_vm-debug_test-mochitest-e10s-2-bm125-tests1-linux64-build2.txt:5
> mozilla-central_ubuntu64_vm-debug_test-mochitest-2-bm131-tests1-linux64-build7.txt:5
> mozilla-central_ubuntu64_vm-debug_test-crashtest-e10s-bm53-tests1-linux64-build4.txt:2
> mozilla-central_ubuntu64_vm-debug_test-crashtest-bm67-tests1-linux64-build6.txt:2
> mozilla-central_ubuntu64_vm-debug_test-mochitest-e10s-6-bm115-tests1-linux64-build5.txt:1
> mozilla-central_ubuntu64_vm-debug_test-mochitest-6-bm117-tests1-linux64-build3.txt:1

It shows up in 62 tests. A few of the most prevalent:

> 1410 - /html/semantics/embedded-content/the-img-element/srcset/parse-a-srcset-attribute.html
> 297 - parser/htmlparser/tests/mochitest/test_img_picture_preload.html
> 128 - /html/semantics/embedded-content/the-img-element/update-the-source-set.html
> 78 - /html/semantics/embedded-content/the-img-element/srcset/select-an-image-source.html
> 78 - /html/semantics/embedded-content/the-img-element/current-pixel-density/basic.html
> 40 - layout/style/test/test_bug418986-2.html
> 40 - dom/security/test/mixedcontentblocker/test_main.html
> 36 - dom/tests/mochitest/general/test_picture_pref.html
> 30 - /html/semantics/embedded-content/the-img-element/current-pixel-density/error.html
> 16 - layout/style/test/chrome/test_bug418986-2.xul

[1] https://hg.mozilla.org/mozilla-central/annotate/b6683e141c47/dom/base/ResponsiveImageSelector.cpp#l280
Whiteboard: [tw-dom] btpp-fixlater
This is now the #2 most verbose warning during testing.

Edgar, it looks like you were the last one to modify this code in bug 1257742, can you take a look?
Flags: needinfo?(echen)
Summary: 2,400 instances of "NS_ENSURE_TRUE(!mDefaultSourceURL.IsEmpty()) failed" emitted from dom/base/ResponsiveImageSelector.cpp during linux64 debug testing → 6,300 instances of "NS_ENSURE_TRUE(!mDefaultSourceURL.IsEmpty()) failed" emitted from dom/base/ResponsiveImageSelector.cpp during linux64 debug testing
Assignee: nobody → echen
Flags: needinfo?(echen)
Whiteboard: [tw-dom] btpp-fixlater → [tw-dom] btpp-active
Blocks: 1257742
Attached patch Patch, v1Splinter Review
Attachment #8743143 - Flags: review+
Thank you, Josh.
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/4ad8af91152f
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla48
Component: DOM → DOM: Core & HTML
You need to log in before you can comment on or make changes to this bug.