126296 - clean up nsIMessengerWindowService, nsMessengerBootStrap.cpp, mailWindowOverlay.js

Status: RESOLVED EXPIRED

(SeaMonkey :: MailNews: Message Display, defect)

Description

[(not reading, please use [e-mail] instead)]

clean up nsIMessengerWindowService, nsMessengerBootStrap.cpp, mailWindowOverlay.js

we've got some duplicate code in nsMesengerBootStrap.cpp and
mailWindowOverlay.js to open a 3 pane (or a stand alone msg window) given a
folder uri and a message key.

we need to move all this code to C++, and add to the nsIMessengerWindowService
interface.

I think we should fix nsIMessengerWindowService to have open method,

// if msgKey is nsMsgKey_none, will just select the folder
openMessengerWindowWithUri(in string windowType, in string folderUri, in msgKey key)

window type:  "mail:3pane" or "mail:messageWindow"

then, we need to fix the C++ implemenation handle these cases.

for mail:3pane, we need to check the pane config pref, to decide which type of 3
pane to launch.

then we need to fix the JS in mailWindowOverlay.js to use this code.

by fixing the C++, we'll fix the problem where news://host/group urls aren't
selecting the newsgroup.

then, we can extend the C++ impl to heed the "re-use open windows" pref, and
use the window mediator to find the most recent window of that type, if the user
has set their prefs to re-use windows, instead of opening new windows.

bienvenu is going to work on part of this.

Comment 1

[(not reading, please use [e-mail] instead)]

better yet:

openMessengerWindowWithUri(in string windowType, in string uri)

uri is of the form:

news://news.mozilla.org/netscape.test
news://news.mozilla.org/netscape.test#100
mailbox://sspitzer@nsmail-1/Inbox
mailbox://sspitzer@nsmail-1/Inbox#3

you get the idea.

Comment 2

[(not reading, please use [e-mail] instead)]

another reason to make it a string, and not a nsIURI

if the caller has a nsIURI, we can easily do getspec.

but if I only have a spec, I'd have to create a nsIURI to use this.

I want it to be a string, so that we can call this from everywhere, and I'm sure
some of the callers will be from JS, where we just have a nsIMsgFolder and
msgHdr, or just a message uri.

Comment 3

[Robert Kaiser]

MASS-CHANGE:
This bug report is registered in the SeaMonkey product, but has been without a comment since the inception of the SeaMonkey project. This means that it was logged against the old Mozilla suite and we cannot determine that it's still valid for the current SeaMonkey suite. Because of this, we are setting it to an UNCONFIRMED state.

If you can confirm that this report still applies to current SeaMonkey 2.x nightly builds, please set it back to the NEW state along with a comment on how you reproduced it on what Build ID, or if it's an enhancement request, why it's still worth implementing and in what way.
If you can confirm that the report doesn't apply to current SeaMonkey 2.x nightly builds, please set it to the appropriate RESOLVED state (WORKSFORME, INVALID, WONTFIX, or similar).
If no action happens within the next few months, we move this bug report to an EXPIRED state.

Query tag for this change: mass-UNCONFIRM-20090614

Comment 4

[Robert Kaiser]

MASS-CHANGE:
This bug report is registered in the SeaMonkey product, but still has no comment since the inception of the SeaMonkey project 5 years ago.

Because of this, we're resolving the bug as EXPIRED.

If you still can reproduce the bug on SeaMonkey 2 or otherwise think it's still valid, please REOPEN it and if it is a platform or toolkit issue, move it to the according component.

Query tag for this change: EXPIRED-20100420