Closed Bug 1262961 Opened 6 years ago Closed 6 years ago
Missing stats for recent debug builds in perfherder
MozReview Request: Bug 1262961 - Add the 'generate-build-stats' step to several debug mozharness configs. r=mshal
58 bytes, text/x-review-board-request
These are mostly missing due to bug 1251713, the step is just commented out in those configs for whatever reason.
I'll leave them off for linux buildbot builds, as we learned in bug 1262538 we're measuring taskcluster builds in that graph now.
Review commit: https://reviewboard.mozilla.org/r/45077/diff/#index_header See other reviews: https://reviewboard.mozilla.org/r/45077/
Attachment #8739167 - Flags: review?(mshal)
The generate-build-stats step originated from bug 579131 in buildbot-land, where it just counted ctors in Linux opt builds. So when that was ported to mozharness, the action was only enabled in the Linux opt configs. However, generate-build-stats seems to have grown its responsibilities now from bug 1251713 as you mentioned. Fortunately the ctors counting is also guarded by the enable_count_ctors config property, so this should be fine to enable on other platforms. Can you get rid of this duplicate if-statement while you're in there? https://dxr.mozilla.org/mozilla-central/rev/29d5a4175c8b74f45482276a53985cf2568b4be2/testing/mozharness/mozharness/mozilla/building/buildbase.py#1834
Comment on attachment 8739167 [details] MozReview Request: Bug 1262961 - Add the 'generate-build-stats' step to several debug mozharness configs. r=mshal https://reviewboard.mozilla.org/r/45077/#review42057
Attachment #8739167 - Flags: review?(mshal) → review+
You need to log in before you can comment on or make changes to this bug.