Make mach ask npm what the path to eslint is if it can't find it in the searchable path

RESOLVED FIXED in Firefox 48

Status

Testing
General
RESOLVED FIXED
2 years ago
2 years ago

People

(Reporter: mossop, Assigned: mossop)

Tracking

Version 3
mozilla48
Points:
---

Firefox Tracking Flags

(firefox48 fixed)

Details

MozReview Requests

Submitter Diff Changes Open Issues Last Updated
Loading...
Error loading review requests:

Attachments

(1 attachment)

(Assignee)

Description

2 years ago
Setting up paths to make npm work on Windows is sort of a pain, but npm will tell you where the binaries are at if you ask it nicely enough.
(Assignee)

Comment 1

2 years ago
Created attachment 8739181 [details]
MozReview Request: Bug 1262978: Run npm to get the path to installed binaries if eslint can't otherwise be found. r?gps

Review commit: https://reviewboard.mozilla.org/r/45091/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/45091/
Attachment #8739181 - Flags: review?(gps)

Comment 2

2 years ago
Comment on attachment 8739181 [details]
MozReview Request: Bug 1262978: Run npm to get the path to installed binaries if eslint can't otherwise be found. r?gps

https://reviewboard.mozilla.org/r/45091/#review41767

Cool.
Attachment #8739181 - Flags: review?(gps) → review+

Comment 4

2 years ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/7ddc5c22f132
Status: NEW → RESOLVED
Last Resolved: 2 years ago
status-firefox48: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla48

Updated

2 years ago
Depends on: 1268752
You need to log in before you can comment on or make changes to this bug.