1263018 - Only update active program info if calling LinkProgram on the active program

Status: RESOLVED FIXED

(Core :: Graphics: CanvasWebGL, defect)

Description

[Kelsey Gilbert [:jgilbert]]

Right now LinkProgram will update the active program info even if `prog != mCurrentProgram`.

Luckily this doesn't often bite us in real code.

Comment 1

[Kelsey Gilbert [:jgilbert]]

Attachment: MozReview Request: Bug 1263018 - Only update mActiveProgramLinkInfo if re-linking active

From cf341928a4b3afc660ec84cc3fa6f7f1112861ea Mon Sep 17 00:00:00 2001
 prog
r?jrmuizel
---
 dom/canvas/WebGLContextGL.cpp | 11 ++++++++---
 dom/canvas/WebGLProgram.cpp   | 30 ++++++++++++------------------
 dom/canvas/WebGLProgram.h     |  4 ++--
 3 files changed, 22 insertions(+), 23 deletions(-)

Review commit: https://reviewboard.mozilla.org/r/45147/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/45147/

Comment 2

[Kelsey Gilbert [:jgilbert]]

Attachment: MozReview Request: Clarify what we're testing. r?jrmuizel

From a2553704a36aee463e33df74c0b023ec4cf86ba8 Mon Sep 17 00:00:00 2001
---
 dom/canvas/WebGLContextDraw.cpp | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)

Review commit: https://reviewboard.mozilla.org/r/45149/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/45149/

Comment 3

[Jeff Muizelaar [:jrmuizel]]

Comment on attachment 8739244 [details]
MozReview Request: Clarify what we're testing. r?jrmuizel

https://reviewboard.mozilla.org/r/45149/#review44025

Sorry this took so long

Comment 4

[Kelsey Gilbert [:jgilbert]]

My bad, looks like the initial patch's review tag got clipped from the summary.

Comment 5

[Jeff Muizelaar [:jrmuizel]]

Comment on attachment 8739243 [details]
MozReview Request: Bug 1263018 - Only update mActiveProgramLinkInfo if re-linking active

https://reviewboard.mozilla.org/r/45147/#review44289

Comment 6

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/dccbf2ad3fa2

Comment 7

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/dccbf2ad3fa2