Closed
Bug 1263018
Opened 8 years ago
Closed 8 years ago
Only update active program info if calling LinkProgram on the active program
Categories
(Core :: Graphics: CanvasWebGL, defect)
Core
Graphics: CanvasWebGL
Tracking
()
RESOLVED
FIXED
mozilla48
Tracking | Status | |
---|---|---|
firefox48 | --- | fixed |
People
(Reporter: jgilbert, Assigned: jgilbert)
Details
Attachments
(2 files)
Right now LinkProgram will update the active program info even if `prog != mCurrentProgram`. Luckily this doesn't often bite us in real code.
Assignee | ||
Comment 1•8 years ago
|
||
From cf341928a4b3afc660ec84cc3fa6f7f1112861ea Mon Sep 17 00:00:00 2001 prog r?jrmuizel --- dom/canvas/WebGLContextGL.cpp | 11 ++++++++--- dom/canvas/WebGLProgram.cpp | 30 ++++++++++++------------------ dom/canvas/WebGLProgram.h | 4 ++-- 3 files changed, 22 insertions(+), 23 deletions(-) Review commit: https://reviewboard.mozilla.org/r/45147/diff/#index_header See other reviews: https://reviewboard.mozilla.org/r/45147/
Attachment #8739244 -
Flags: review?(jmuizelaar)
Assignee | ||
Comment 2•8 years ago
|
||
From a2553704a36aee463e33df74c0b023ec4cf86ba8 Mon Sep 17 00:00:00 2001 --- dom/canvas/WebGLContextDraw.cpp | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) Review commit: https://reviewboard.mozilla.org/r/45149/diff/#index_header See other reviews: https://reviewboard.mozilla.org/r/45149/
Assignee | ||
Updated•8 years ago
|
Flags: needinfo?(jmuizelaar)
Comment 3•8 years ago
|
||
Comment on attachment 8739244 [details] MozReview Request: Clarify what we're testing. r?jrmuizel https://reviewboard.mozilla.org/r/45149/#review44025 Sorry this took so long
Attachment #8739244 -
Flags: review?(jmuizelaar) → review+
Assignee | ||
Updated•8 years ago
|
Attachment #8739243 -
Flags: review?(jmuizelaar)
Assignee | ||
Comment 4•8 years ago
|
||
My bad, looks like the initial patch's review tag got clipped from the summary.
Flags: needinfo?(jmuizelaar)
Updated•8 years ago
|
Attachment #8739243 -
Flags: review?(jmuizelaar) → review+
Comment 5•8 years ago
|
||
Comment on attachment 8739243 [details] MozReview Request: Bug 1263018 - Only update mActiveProgramLinkInfo if re-linking active https://reviewboard.mozilla.org/r/45147/#review44289
Comment 7•8 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/dccbf2ad3fa2
Status: NEW → RESOLVED
Closed: 8 years ago
status-firefox48:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla48
You need to log in
before you can comment on or make changes to this bug.
Description
•