Closed Bug 1263073 Opened 4 years ago Closed 4 years ago

partner repacks should not block other uploads

Categories

(Release Engineering :: Release Automation: Other, defect)

defect
Not set

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: rail, Assigned: rail)

References

Details

Attachments

(2 files)

* we should not block push to releases
* partner repacks should depend only on l10n per platform
* push to releases probably should not overwrite files instead of checking if the top directory exists
Assignee: nobody → rail
I ran this against staging multiple times and it seems to work.
Attachment #8740230 - Flags: review?(nthomas) → review+
Comment on attachment 8740230 [details]
MozReview Request: Bug 1263073 - partner repacks should not block other uploads r=nthomas a=release DONTBUILD

https://reviewboard.mozilla.org/r/45651/#review42167

r+ with the merge collision removed.

::: testing/mozharness/scripts/release/push-candidate-to-releases.py:161
(Diff revision 1)
>  
> +            def copy_key():
> +                dest_key = bucket.get_key(destination)
> +                source_key = bucket.get_key(source)
> +                if not dest_key:
> -            self.info("Copying {} to {}".format(source, destination))
> +                    self.info("Copying {} to {}".format(source, destination))

Leftover collision goo here (>>>>>>>>).
(In reply to Nick Thomas [:nthomas] from comment #3)
> Leftover collision goo here (>>>>>>>>).

FTR, this is how reviewboard represents space changes.
Attached file PR for releasetasks
Attachment #8740403 - Flags: review?(jlund)
Attachment #8740403 - Flags: review?(jlund) → review+
Attachment #8740403 - Flags: checked-in+
deployed
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Depends on: 1265074
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
I don't think we should reopen this bug since it works fine unless you want to overwrite files with different content.
Status: REOPENED → RESOLVED
Closed: 4 years ago4 years ago
Resolution: --- → FIXED
Removing leave-open keyword from resolved bugs, per :sylvestre.
Keywords: leave-open
You need to log in before you can comment on or make changes to this bug.