1263073 - partner repacks should not block other uploads

Status: RESOLVED FIXED

(Release Engineering :: Release Automation: Other, defect)

Description

[Rail Aliiev [:rail]]

* we should not block push to releases
* partner repacks should depend only on l10n per platform
* push to releases probably should not overwrite files instead of checking if the top directory exists

Comment 1

[Rail Aliiev [:rail]]

Attachment: MozReview Request: Bug 1263073 - partner repacks should not block other uploads r=nthomas a=release DONTBUILD

Review commit: https://reviewboard.mozilla.org/r/45651/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/45651/

Comment 2

[Rail Aliiev [:rail]]

I ran this against staging multiple times and it seems to work.

Comment 3

[Nick Thomas [:nthomas] (UTC+12)]

Comment on attachment 8740230 [details]
MozReview Request: Bug 1263073 - partner repacks should not block other uploads r=nthomas a=release DONTBUILD

https://reviewboard.mozilla.org/r/45651/#review42167

r+ with the merge collision removed.

::: testing/mozharness/scripts/release/push-candidate-to-releases.py:161
(Diff revision 1)
>  
> +            def copy_key():
> +                dest_key = bucket.get_key(destination)
> +                source_key = bucket.get_key(source)
> +                if not dest_key:
> -            self.info("Copying {} to {}".format(source, destination))
> +                    self.info("Copying {} to {}".format(source, destination))

Leftover collision goo here (>>>>>>>>).

Comment 4

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/cd662dfd05fe

Comment 5

[Rail Aliiev [:rail]]

Comment on attachment 8740230 [details]
MozReview Request: Bug 1263073 - partner repacks should not block other uploads r=nthomas a=release DONTBUILD

https://hg.mozilla.org/integration/mozilla-inbound/rev/cd662dfd05fe
https://hg.mozilla.org/releases/mozilla-aurora/rev/cf019107c664
https://hg.mozilla.org/releases/mozilla-beta/rev/8078007962a8
https://hg.mozilla.org/releases/mozilla-esr45/rev/6da110abe7ed

Comment 6

[Rail Aliiev [:rail]]

(In reply to Nick Thomas [:nthomas] from comment #3)
> Leftover collision goo here (>>>>>>>>).

FTR, this is how reviewboard represents space changes.

Comment 7

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/cd662dfd05fe

Comment 8

[Rail Aliiev [:rail]]

Attachment: PR for releasetasks

Comment 9

[Rail Aliiev [:rail]]

deployed

Comment 10

[Rail Aliiev [:rail]]

I don't think we should reopen this bug since it works fine unless you want to overwrite files with different content.

Comment 11

[Firefox Bug Husbandry Bot]

Removing leave-open keyword from resolved bugs, per :sylvestre.