Closed Bug 1263077 Opened 4 years ago Closed 4 years ago

Stop using parseInt when specifying octal numbers now that JS has the new octal notation

Categories

(Add-on SDK Graveyard :: General, defect)

defect
Not set

Tracking

(firefox48 fixed)

RESOLVED FIXED
mozilla48
Tracking Status
firefox48 --- fixed

People

(Reporter: jwatt, Assigned: jwatt)

Details

Attachments

(1 file)

When "0" prefixed octal literals were deprecated back around 2010 we changed a bunch of code over to using parseInt("<octal-string>", 8); for example, see bug 572890. Nowadays we support the new "0o" prefix for octal literals and no longer need to use parseInt.
Attached patch patchSplinter Review
Attachment #8739305 - Flags: review?(dietrich)
Comment on attachment 8739305 [details] [diff] [review]
patch

Review of attachment 8739305 [details] [diff] [review]:
-----------------------------------------------------------------

Switching review to Matteo, who I believe is module owner of SDK.
Attachment #8739305 - Flags: review?(dietrich) → review?(zer0)
Comment on attachment 8739305 [details] [diff] [review]
patch

Review of attachment 8739305 [details] [diff] [review]:
-----------------------------------------------------------------

LGTM, r+ if all tests are passing.
Attachment #8739305 - Flags: review?(zer0) → review+
https://hg.mozilla.org/mozilla-central/rev/3c2c25159286
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla48
You need to log in before you can comment on or make changes to this bug.