Closed Bug 1263158 Opened 4 years ago Closed 4 years ago

Avoid JavaScript strict warning in AppsUtils.jsm during startup

Categories

(Core Graveyard :: DOM: Apps, defect)

defect
Not set

Tracking

(firefox48 fixed)

RESOLVED FIXED
mozilla48
Tracking Status
firefox48 --- fixed

People

(Reporter: jwatt, Assigned: marco)

Details

Attachments

(1 file)

During startup I get:

JavaScript strict warning: resource://gre/modules/AppsUtils.jsm, line 839: ReferenceError: reference to undefined property this._manifest[aProp]

(aProp == "widgetPages")

It would be really nice to get this clutter out of the startup output to make debugging real startup issues easier.
Fabrice, this is code you wrote. Any idea how to properly fix this?

https://mxr.mozilla.org/mozilla-central/source/dom/apps/AppsUtils.jsm?rev=a85b572e0d8c#842
Flags: needinfo?(fabrice)
Assignee: nobody → mcastelluccio
Status: NEW → ASSIGNED
Attachment #8739431 - Flags: review?(fabrice)
Attachment #8739431 - Flags: review?(fabrice) → review+
Flags: needinfo?(fabrice)
https://hg.mozilla.org/integration/mozilla-inbound/rev/ac43dab284afd189ed2b0f4c1906a45e0c1736dd
Bug 1263158 - Check if key is present in manifest object before using it. r=fabrice
https://hg.mozilla.org/mozilla-central/rev/ac43dab284af
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla48
Product: Core → Core Graveyard
You need to log in before you can comment on or make changes to this bug.