1263160 - Edit as HTML isn't working

Status: RESOLVED WORKSFORME

(DevTools :: Inspector, defect)

Description

[Brian Grinstead [:bgrins]]

STR:
Open a page
Right click on an element
Edit as HTML

Expected
HTML Editor opens

Actual
Nothing happens

Comment 1

[Brian Grinstead [:bgrins]]

First error I see when the inspector opens: JavaScript error: chrome://devtools/content/sourceeditor/codemirror/lib/codemirror.js, line 126: TypeError: getComputedStyle(...) is null

Second error I see after trying to edit:

*************************
A coding exception was thrown in a Promise resolution callback.
See https://developer.mozilla.org/Mozilla/JavaScript_code_modules/Promise.jsm/Promise

Full message: TypeError: cm is undefined
Full stack: Editor.prototype.setText@resource://gre/modules/commonjs/toolkit/loader.js -> resource://devtools/client/sourceeditor/editor.js:545:5
HTMLEditor.prototype.show@resource://gre/modules/commonjs/toolkit/loader.js -> resource://devtools/client/inspector/markup/html-editor.js:126:5
MarkupView.prototype.beginEditingOuterHTML/<@resource://gre/modules/commonjs/toolkit/loader.js -> resource://devtools/client/inspector/markup/markup.js:1298:7
Handler.prototype.process@resource://gre/modules/Promise.jsm -> resource://gre/modules/Promise-backend.js:937:23
this.PromiseWalker.walkerLoop@resource://gre/modules/Promise.jsm -> resource://gre/modules/Promise-backend.js:816:7
Promise*this.PromiseWalker.scheduleWalkerLoop@resource://gre/modules/Promise.jsm -> resource://gre/modules/Promise-backend.js:747:11
this.PromiseWalker.schedulePromise@resource://gre/modules/Promise.jsm -> resource://gre/modules/Promise-backend.js:779:7
this.PromiseWalker.completePromise@resource://gre/modules/Promise.jsm -> resource://gre/modules/Promise-backend.js:714:7
Front<.onPacket/<@resource://gre/modules/commonjs/toolkit/loader.js -> resource://devtools/server/protocol.js:1236:9
DevTools RDP*Front<.request@resource://gre/modules/commonjs/toolkit/loader.js -> resource://devtools/server/protocol.js:1178:7
frontProto/</proto[name]@resource://gre/modules/commonjs/toolkit/loader.js -> resource://devtools/server/protocol.js:1338:14
MarkupView.prototype._getNodeHTML@resource://gre/modules/commonjs/toolkit/loader.js -> resource://devtools/client/inspector/markup/markup.js:1095:23
MarkupView.prototype.getNodeOuterHTML@resource://gre/modules/commonjs/toolkit/loader.js -> resource://devtools/client/inspector/markup/markup.js:1116:12
MarkupView.prototype.beginEditingOuterHTML@resource://gre/modules/commonjs/toolkit/loader.js -> resource://devtools/client/inspector/markup/markup.js:1293:5
InspectorPanel.prototype.editHTML@resource://gre/modules/commonjs/toolkit/loader.js -> resource://devtools/client/inspector/inspector-panel.js:1148:7
oncommand@chrome://devtools/content/inspector/inspector.xul:1:1

*************************

Comment 2

[Patrick Brosset <:pbro>]

Looks like Gabriel and Julian weren't able to reproduce this one Brian, can you check again please?

Comment 3

[Brian Grinstead [:bgrins]]

OK, retested on a clean profile and the problem went away, so closing.  For future reference, the addons I have installed on the failing profile: Force RTL, RDP Inspector, and Remote XUL Manager