If you think a bug might affect users in the 57 release, please set the correct tracking and status flags for Release Management.

Implement getComputedStyle for text properties

RESOLVED FIXED in mozilla1.0

Status

()

Core
DOM: CSS Object Model
P2
normal
RESOLVED FIXED
16 years ago
16 years ago

People

(Reporter: Christopher Aillon (sabbatical, not receiving bugmail), Assigned: Christopher Aillon (sabbatical, not receiving bugmail))

Tracking

(Blocks: 1 bug)

Trunk
mozilla1.0
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

(URL)

Attachments

(1 attachment, 2 obsolete attachments)

6.42 KB, patch
Christopher Aillon (sabbatical, not receiving bugmail)
: review+
Christopher Aillon (sabbatical, not receiving bugmail)
: superreview+
Details | Diff | Splinter Review
text-align and text-decoration are already implemented.

This bug will cover text-indent, text-transform, letter-spacing, word-spacing,
and white-space.
Created attachment 70226 [details] [diff] [review]
Patch v1.0
Created attachment 70350 [details] [diff] [review]
Patch v1.1

Fix two |val->SetString(NS_LITERAL_STRING(""));| to be the default values.
Silly me :)
Attachment #70226 - Attachment is obsolete: true
r=hixie from a CSS point of view, as long as the sr= is familiar with this code
and looks at the C++ carefully.
Comment on attachment 70350 [details] [diff] [review]
Patch v1.1

Adding Hixie's review
Attachment #70350 - Flags: review+
->1.0
Blocks: 42417
Status: NEW → ASSIGNED
Keywords: patch
Priority: -- → P2
Target Milestone: --- → mozilla1.0

Comment 6

16 years ago
Comment on attachment 70350 [details] [diff] [review]
Patch v1.1

sr=attinasi
Attachment #70350 - Flags: superreview+
Comment on attachment 70350 [details] [diff] [review]
Patch v1.1

r=bzbarsky as well, looks great
Created attachment 72281 [details] [diff] [review]
Patch v1.11

Same as attachment 70350 [details] [diff] [review], but moves a function definition to a more sane place.


Was: GetTextDecoration(), GetVisibility(), GetTextIndent(),
GetTextTransform()...

Now: GetTextDecoration(), GetTextIndent(), GetTextTransform()...
GetVisibility()
Attachment #70350 - Attachment is obsolete: true
Comment on attachment 72281 [details] [diff] [review]
Patch v1.11

Transferring r=bzbarsky, sr=attinasi
Attachment #72281 - Flags: superreview+
Attachment #72281 - Flags: review+
Comment on attachment 72281 [details] [diff] [review]
Patch v1.11

a=roc+moz for trunk
Attachment #72281 - Flags: approval+
checked in on the trunk.  Thanks, Christopher!
Status: ASSIGNED → RESOLVED
Last Resolved: 16 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.