1263373 - Intermittent service-workers/service-worker/fetch-header-visibility.https.html | Visibility of defaulted headers during interception - Test timed out

Status: RESOLVED INCOMPLETE

(Core :: DOM: Service Workers, defect, P5)

Description

[Ryan VanderMeulen [:RyanVM]]

https://treeherder.mozilla.org/logviewer.html#?job_id=25430652&repo=mozilla-inbound

Comment 1

[Ben Kelly [:bkelly, not reviewing]]

Let's see if this reproduces much before spending a lot of time here.  Nothing immediately jumps out at me.

Comment 2

[BMO Automation]

Bulk assigning P3 to all open intermittent bugs without a priority set in Firefox components per bug 1298978.

Comment 3

[Cătălin Badea (:catalinb)]

Attachment: Don't respondWith twice in fetch-rewrite-worker.js

Comment 4

[Ben Kelly [:bkelly, not reviewing]]

Comment on attachment 8809581 [details] [diff] [review]
Don't respondWith twice in fetch-rewrite-worker.js

Review of attachment 8809581 [details] [diff] [review]:
-----------------------------------------------------------------

How is this an intermittent and not always a failure?

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/85bef7bdcafc
Don't respondWith twice in fetch-rewrite-worker.js r=bkelly

Comment 6

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/85bef7bdcafc

Comment 7

[Cătălin Badea (:catalinb)]

(In reply to Ben Kelly [:bkelly] from comment #4)
> Comment on attachment 8809581 [details] [diff] [review]
> Don't respondWith twice in fetch-rewrite-worker.js
> 
> Review of attachment 8809581 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> How is this an intermittent and not always a failure?

This was not the issue. I assumed this was causing the intermittent failure because I only recently started
to see a failure of this test in my try runs for bug 1263304. According to the spec, the fetch event should
still successfully respond even if there's a second respondWith call that throws. My patches were breaking this, causing the failure I was seeing.

The patch itself is not a bad change, but it didn't fix whatever is causing the intermittent failure.

Comment 8

[BugBot [:suhaib / :marco/ :calixte]]

https://wiki.mozilla.org/Bug_Triage#Intermittent_Test_Failure_Cleanup
For more information, please visit auto_nag documentation.