Closed
Bug 1263441
Opened 9 years ago
Closed 9 years ago
Use a specific string for link to Firefox Account in new promo text
Categories
(Firefox :: Sync, defect)
Firefox
Sync
Tracking
()
RESOLVED
FIXED
Firefox 48
Tracking | Status | |
---|---|---|
firefox48 | --- | fixed |
People
(Reporter: flod, Assigned: eoger)
References
Details
Attachments
(1 file, 1 obsolete file)
5.47 KB,
patch
|
flod
:
review+
|
Details | Diff | Splinter Review |
This landed in bug 1241319
https://hg.mozilla.org/mozilla-central/diff/0611a1fb8d39/browser/locales/en-US/chrome/browser/browser.properties
> # %3$S will be replace by the content of syncBrand.fxAccount.label (Firefox Account)
> appMenuRemoteTabs.mobilePromo.text = Download %1$S or %2$S and connect them to your %3$S.
"Firefox Account" is a "localizable" brand (the "account" part)
https://transvision.mozfr.org/string/?entity=browser/chrome/browser/syncBrand.dtd:syncBrand.fxAccount.label&repo=aurora
Reusing the generic brand string makes extremely difficult (or impossible) to create a natural sounding sentence for locales with grammar cases. Even with a language as simple as Italian it looks wrong, since "account" in the middle of a sentence should be lowercase.
At this point the main label would need a new ID too to make sure localizers are aware of the change.
appMenuRemoteTabs.mobilePromo.text2 = Download %1$S or %2$S and connect them to your %3$S.
appMenuRemoteTabs.mobilePromo.fxa = Firefox Account
Also, typo in the current comment should be fixed ("…will be replaceD by…").
Assignee | ||
Comment 1•9 years ago
|
||
Thank you for your feedback Francesco.
Comment 2•9 years ago
|
||
Comment on attachment 8739793 [details] [diff] [review]
bug-1263441.patch
Review of attachment 8739793 [details] [diff] [review]:
-----------------------------------------------------------------
Thanks Flod - do you mind taking the review?
Attachment #8739793 -
Flags: review?(markh) → review?(francesco.lodolo)
Reporter | ||
Comment 3•9 years ago
|
||
Comment on attachment 8739793 [details] [diff] [review]
bug-1263441.patch
Review of attachment 8739793 [details] [diff] [review]:
-----------------------------------------------------------------
I need one confirmation after looking at the code: is the "Firefox Account" used to create an active link like the other 2 placeholders? I don't think so, in which case we can simplify it drastically (no need for a placeholder at all).
appMenuRemoteTabs.mobilePromo.text2 = Download %1$S or %2$S and connect them to your Firefox Account.
::: browser/locales/en-US/chrome/browser/browser.properties
@@ +688,2 @@
>
> # LOCALIZATION NOTE (appMenuRemoteTabs.mobilePromo.text):
Nit: text2
Reporter | ||
Updated•9 years ago
|
Flags: needinfo?(edouard.oger)
Assignee | ||
Comment 4•9 years ago
|
||
Sounds good
Attachment #8739793 -
Attachment is obsolete: true
Attachment #8739793 -
Flags: review?(francesco.lodolo)
Flags: needinfo?(edouard.oger)
Attachment #8740044 -
Flags: review?(francesco.lodolo)
Reporter | ||
Comment 5•9 years ago
|
||
Comment on attachment 8740044 [details] [diff] [review]
bug-1263441.patch
Review of attachment 8740044 [details] [diff] [review]:
-----------------------------------------------------------------
Looks good to me, thanks!
Attachment #8740044 -
Flags: review?(francesco.lodolo) → review+
Assignee | ||
Updated•9 years ago
|
Keywords: checkin-needed
Keywords: checkin-needed
Comment 7•9 years ago
|
||
bugherder landing |
Comment 8•9 years ago
|
||
bugherder |
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
status-firefox48:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 48
You need to log in
before you can comment on or make changes to this bug.
Description
•