1263442 - On dark GTK themes the toolbar menubuttons are lighter than the other buttons

Status: RESOLVED FIXED

(Thunderbird :: Theme, defect)

Description

[Richard Marti (:Paenglab)]

Attachment: DarkThemeButton.png

Especially on the message headers is the difference good visible.

Comment 1

[Richard Marti (:Paenglab)]

Attachment: linuxButtonFix.patch

This happens because the semi transparent background is applied on toolbarbutton-1[type="menu-button"] and on the .toolbarbutton-menubutton-button/.toolbarbutton-menubutton-dropmarker.

On light themes this isn't visible.

Comment 2

[Magnus Melin [:mkmelin]]

Comment on attachment 8739775 [details] [diff] [review]
linuxButtonFix.patch

Review of attachment 8739775 [details] [diff] [review]:
-----------------------------------------------------------------

Ah details:) r=mkmelin

Comment 3

[Richard Marti (:Paenglab)]

http://hg.mozilla.org/comm-central/rev/49c8eeee2f6f

Comment 4

[Richard Marti (:Paenglab)]

Comment on attachment 8739775 [details] [diff] [review]
linuxButtonFix.patch

[Approval Request Comment]
User impact if declined: not consistent toolbar button background colors on toolbars with dark desktop themes.
Testing completed (on c-c, etc.): on c-c
Risk to taking this patch (and alternatives if risky): low

Comment 5

[Jorg K (CEST = GMT+2)]

Aurora (TB 47):
https://hg.mozilla.org/releases/comm-aurora/rev/0c811baa5191

Comment 6

[Kent James (:rkent)]

http://hg.mozilla.org/releases/comm-esr45/rev/bae89c79753c