Closed
Bug 1263442
Opened 5 years ago
Closed 5 years ago
On dark GTK themes the toolbar menubuttons are lighter than the other buttons
Categories
(Thunderbird :: Theme, defect)
Tracking
(thunderbird46 wontfix, thunderbird47 fixed, thunderbird48 fixed, thunderbird_esr4546+ fixed)
RESOLVED
FIXED
Thunderbird 48.0
People
(Reporter: Paenglab, Assigned: Paenglab)
Details
Attachments
(2 files)
5.30 KB,
image/png
|
Details | |
5.22 KB,
patch
|
mkmelin
:
review+
jorgk-bmo
:
approval-comm-aurora+
jorgk-bmo
:
approval-comm-beta-
rkent
:
approval-comm-esr45+
|
Details | Diff | Splinter Review |
Especially on the message headers is the difference good visible.
Assignee | ||
Comment 1•5 years ago
|
||
This happens because the semi transparent background is applied on toolbarbutton-1[type="menu-button"] and on the .toolbarbutton-menubutton-button/.toolbarbutton-menubutton-dropmarker. On light themes this isn't visible.
Assignee: nobody → richard.marti
Status: NEW → ASSIGNED
Attachment #8739775 -
Flags: review?(mkmelin+mozilla)
Comment 2•5 years ago
|
||
Comment on attachment 8739775 [details] [diff] [review] linuxButtonFix.patch Review of attachment 8739775 [details] [diff] [review]: ----------------------------------------------------------------- Ah details:) r=mkmelin
Attachment #8739775 -
Flags: review?(mkmelin+mozilla) → review+
Assignee | ||
Comment 3•5 years ago
|
||
http://hg.mozilla.org/comm-central/rev/49c8eeee2f6f
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 48.0
Assignee | ||
Comment 4•5 years ago
|
||
Comment on attachment 8739775 [details] [diff] [review] linuxButtonFix.patch [Approval Request Comment] User impact if declined: not consistent toolbar button background colors on toolbars with dark desktop themes. Testing completed (on c-c, etc.): on c-c Risk to taking this patch (and alternatives if risky): low
Attachment #8739775 -
Flags: approval-comm-esr45?
Attachment #8739775 -
Flags: approval-comm-beta?
Attachment #8739775 -
Flags: approval-comm-aurora?
Updated•5 years ago
|
Attachment #8739775 -
Flags: approval-comm-aurora? → approval-comm-aurora+
Comment 5•5 years ago
|
||
Aurora (TB 47): https://hg.mozilla.org/releases/comm-aurora/rev/0c811baa5191
status-thunderbird46:
--- → affected
status-thunderbird47:
--- → fixed
status-thunderbird48:
--- → fixed
status-thunderbird_esr45:
--- → affected
tracking-thunderbird_esr45:
--- → +
Updated•5 years ago
|
Attachment #8739775 -
Flags: approval-comm-esr45? → approval-comm-esr45+
Updated•5 years ago
|
Attachment #8739775 -
Flags: approval-comm-beta? → approval-comm-beta-
Updated•5 years ago
|
You need to log in
before you can comment on or make changes to this bug.
Description
•