Closed Bug 1263472 Opened 5 years ago Closed 5 years ago

fix image/test/mochitest/test_svg_animatedGIF.html

Categories

(Core :: ImageLib, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla49
Tracking Status
firefox49 --- fixed

People

(Reporter: tnikkel, Assigned: tnikkel)

Details

Attachments

(1 file)

This test would fail as a mochitest-chrome (it's since been converted to mochitest-plain where it avoids this problem) when the mochitest-chrome iframe allowed scrolling (bug 1199023). The test element was taller than the reference element, causing a scrollbar. It doesn't happen currently, but we should avoid the problem in case anything changes in the future.
Attached patch patchSplinter Review
Attachment #8739799 - Flags: review?(seth)
Attachment #8739799 - Flags: review?(seth) → review?(bugzilla)
Comment on attachment 8739799 [details] [diff] [review]
patch

Review of attachment 8739799 [details] [diff] [review]:
-----------------------------------------------------------------

I'm not actually familiar with code in image lib, but the description sounds reasonable to me and the code change looks straight forward, so it should be fine I think.
Attachment #8739799 - Flags: review?(bugzilla) → review+
Thanks. Yeah it's a straightforward test fix. No knowledge of imagelib needed.
https://hg.mozilla.org/mozilla-central/rev/c18a17e91f35
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla49
You need to log in before you can comment on or make changes to this bug.