Closed
Bug 1263472
Opened 8 years ago
Closed 8 years ago
fix image/test/mochitest/test_svg_animatedGIF.html
Categories
(Core :: Graphics: ImageLib, defect)
Core
Graphics: ImageLib
Tracking
()
RESOLVED
FIXED
mozilla49
| Tracking | Status | |
|---|---|---|
| firefox49 | --- | fixed |
People
(Reporter: tnikkel, Assigned: tnikkel)
Details
Attachments
(1 file)
|
1.57 KB,
patch
|
xidorn
:
review+
|
Details | Diff | Splinter Review |
This test would fail as a mochitest-chrome (it's since been converted to mochitest-plain where it avoids this problem) when the mochitest-chrome iframe allowed scrolling (bug 1199023). The test element was taller than the reference element, causing a scrollbar. It doesn't happen currently, but we should avoid the problem in case anything changes in the future.
|
Assignee | |
Comment 1•8 years ago
|
||
Attachment #8739799 -
Flags: review?(seth)
|
||
Updated•8 years ago
|
Status: NEW → ASSIGNED
|
|
Assignee | |
Updated•8 years ago
|
Attachment #8739799 -
Flags: review?(seth) → review?(bugzilla)
|
||
Comment 2•8 years ago
|
||
Comment on attachment 8739799 [details] [diff] [review] patch Review of attachment 8739799 [details] [diff] [review]: ----------------------------------------------------------------- I'm not actually familiar with code in image lib, but the description sounds reasonable to me and the code change looks straight forward, so it should be fine I think.
Attachment #8739799 -
Flags: review?(bugzilla) → review+
|
|
Assignee | |
Comment 3•8 years ago
|
||
Thanks. Yeah it's a straightforward test fix. No knowledge of imagelib needed.
|
||
Comment 5•8 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/c18a17e91f35
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
status-firefox49:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla49
You need to log in
before you can comment on or make changes to this bug.
Description
•