1263484 - Remove MEMORY_JS_MAIN_RUNTIME_TEMPORARY_PEAK telemetry measurement

Status: RESOLVED FIXED

(Toolkit :: Telemetry, defect)

Description

[Nicholas Nethercote [inactive]]

MEMORY_JS_MAIN_RUNTIME_TEMPORARY_PEAK was added a long time ago when it could get very high -- e.g. 100s of MiBs -- during JS parsing. But things improved and now it rarely exceeds a handful of MiBs, and it's just not really an interesting thing to report via telemetry any more.

Comment 1

[Nicholas Nethercote [inactive]]

Attachment: Remove the JS_MAIN_RUNTIME_TEMPORARY_PEAK telemetry measurement

I think I found all the spots that needed changing...

Comment 2

[Chris H-C :chutten]

Comment on attachment 8739813 [details] [diff] [review]
Remove the JS_MAIN_RUNTIME_TEMPORARY_PEAK telemetry measurement

Review of attachment 8739813 [details] [diff] [review]:
-----------------------------------------------------------------

That is indeed all the Telemetry stuff.

A casual dxr for JSMainRuntimeTemporaryPeak comes up with 34 results which mostly seem to be self-referential. Can the whole mechanism be removed as well? (Out of scope for this bug of course, but maybe a good first project for someone you want to have learn the internals of JS memory reporting?)

Comment 3

[Nicholas Nethercote [inactive]]

Thank you for the fast review.

> A casual dxr for JSMainRuntimeTemporaryPeak comes up with 34 results which
> mostly seem to be self-referential. Can the whole mechanism be removed as
> well? (Out of scope for this bug of course, but maybe a good first project
> for someone you want to have learn the internals of JS memory reporting?)

Good question. I think it's still a useful thing to show in about:memory, but it's not useful enough to report via telemetry.

Comment 4

[Nicholas Nethercote [inactive]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/9ff4ef78ee4fccb7129a14b0853d58fc690522b1
Bug 1263484 - Remove the JS_MAIN_RUNTIME_TEMPORARY_PEAK telemetry measurement. r=chutten.

Comment 5

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/9ff4ef78ee4f