1263486 - Add a move constructor/assignment operator to nsCSSValue

Status: RESOLVED FIXED

(Core :: CSS Parsing and Computation, defect)

Description

[Brian Birtles (:birtles)]

These objects can be expensive be to copy-construct because in some cases they need to allocate memory on the heap. Some of the work I'm doing in bug 1260655 could be cleaner if we had a move-constructor including:

* Making the return value of GetComputedValue in nsAnimationManager an nsCSSValue object
* Avoiding some clumsiness in AdoptListValue/AdoptPairValueList in nsCSSValue.cpp

Comment 1

[Brian Birtles (:birtles)]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=cb0257116473

Comment 2

[Brian Birtles (:birtles)]

Attachment: MozReview Request: Bug 1263486 part 1 - Add a move constructor and assignment operator to nsCSSValue

Review commit: https://reviewboard.mozilla.org/r/54066/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/54066/

Comment 3

[Brian Birtles (:birtles)]

Attachment: MozReview Request: Bug 1263486 part 2 - Use nsCSSValue move assignment operator in nsCSSValue::Adopt(Pair)ListValue

Review commit: https://reviewboard.mozilla.org/r/54068/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/54068/

Comment 4

[Brian Birtles (:birtles)]

Attachment: MozReview Request: Bug 1263486 part 3 - Use nsCSSValue move constructor in CSSAnimationBuilder::GetComputedValue

Review commit: https://reviewboard.mozilla.org/r/54070/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/54070/

Comment 5

[Cameron McCormack (:heycam)]

Comment on attachment 8754591 [details]
MozReview Request: Bug 1263486 part 1 - Add a move constructor and assignment operator to nsCSSValue

https://reviewboard.mozilla.org/r/54066/#review51094

Comment 6

[Cameron McCormack (:heycam)]

Comment on attachment 8754592 [details]
MozReview Request: Bug 1263486 part 2 - Use nsCSSValue move assignment operator in nsCSSValue::Adopt(Pair)ListValue

https://reviewboard.mozilla.org/r/54068/#review51096

Comment 7

[Cameron McCormack (:heycam)]

Comment on attachment 8754593 [details]
MozReview Request: Bug 1263486 part 3 - Use nsCSSValue move constructor in CSSAnimationBuilder::GetComputedValue

https://reviewboard.mozilla.org/r/54070/#review51098

Comment 8

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/212b7582efe7
https://hg.mozilla.org/integration/mozilla-inbound/rev/e1798579dc7c
https://hg.mozilla.org/integration/mozilla-inbound/rev/d21ddc629993

Comment 9

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/212b7582efe7
https://hg.mozilla.org/mozilla-central/rev/e1798579dc7c
https://hg.mozilla.org/mozilla-central/rev/d21ddc629993