Add a move constructor/assignment operator to nsCSSValue

RESOLVED FIXED in Firefox 49

Status

()

RESOLVED FIXED
3 years ago
3 years ago

People

(Reporter: birtles, Assigned: birtles)

Tracking

Trunk
mozilla49
Points:
---

Firefox Tracking Flags

(firefox48 affected, firefox49 fixed)

Details

Attachments

(3 attachments)

(Assignee)

Description

3 years ago
These objects can be expensive be to copy-construct because in some cases they need to allocate memory on the heap. Some of the work I'm doing in bug 1260655 could be cleaner if we had a move-constructor including:

* Making the return value of GetComputedValue in nsAnimationManager an nsCSSValue object
* Avoiding some clumsiness in AdoptListValue/AdoptPairValueList in nsCSSValue.cpp
(Assignee)

Updated

3 years ago
Assignee: nobody → bbirtles
Status: NEW → ASSIGNED
(Assignee)

Comment 2

3 years ago
Created attachment 8754591 [details]
MozReview Request: Bug 1263486 part 1 - Add a move constructor and assignment operator to nsCSSValue

Review commit: https://reviewboard.mozilla.org/r/54066/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/54066/
Attachment #8754591 - Flags: review?(cam)
Attachment #8754592 - Flags: review?(cam)
Attachment #8754593 - Flags: review?(cam)
(Assignee)

Comment 3

3 years ago
Created attachment 8754592 [details]
MozReview Request: Bug 1263486 part 2 - Use nsCSSValue move assignment operator in nsCSSValue::Adopt(Pair)ListValue

Review commit: https://reviewboard.mozilla.org/r/54068/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/54068/
(Assignee)

Comment 4

3 years ago
Created attachment 8754593 [details]
MozReview Request: Bug 1263486 part 3 - Use nsCSSValue move constructor in CSSAnimationBuilder::GetComputedValue

Review commit: https://reviewboard.mozilla.org/r/54070/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/54070/
Comment on attachment 8754591 [details]
MozReview Request: Bug 1263486 part 1 - Add a move constructor and assignment operator to nsCSSValue

https://reviewboard.mozilla.org/r/54066/#review51094
Attachment #8754591 - Flags: review?(cam) → review+
Attachment #8754592 - Flags: review?(cam) → review+
Comment on attachment 8754592 [details]
MozReview Request: Bug 1263486 part 2 - Use nsCSSValue move assignment operator in nsCSSValue::Adopt(Pair)ListValue

https://reviewboard.mozilla.org/r/54068/#review51096
Attachment #8754593 - Flags: review?(cam) → review+
Comment on attachment 8754593 [details]
MozReview Request: Bug 1263486 part 3 - Use nsCSSValue move constructor in CSSAnimationBuilder::GetComputedValue

https://reviewboard.mozilla.org/r/54070/#review51098

Comment 9

3 years ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/212b7582efe7
https://hg.mozilla.org/mozilla-central/rev/e1798579dc7c
https://hg.mozilla.org/mozilla-central/rev/d21ddc629993
Status: ASSIGNED → RESOLVED
Last Resolved: 3 years ago
status-firefox49: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla49
You need to log in before you can comment on or make changes to this bug.