1263503 - memory leak of filename into layout/printing/nsPrintEngine.cpp

Status: RESOLVED FIXED

(Core :: Printing: Output, defect, P4)

Description

[Makoto Kato [:m_kato]]

https://dxr.mozilla.org/mozilla-central/source/layout/printing/nsPrintEngine.cpp#1682

  nsAutoString fileNameStr;
  // check to see if we are printing to a file
  bool isPrintToFile = false;
  mPrt->mPrintSettings->GetPrintToFile(&isPrintToFile);
  if (isPrintToFile) {
    // On some platforms The BeginDocument needs to know the name of the file.
    char16_t* fileName = nullptr;
    mPrt->mPrintSettings->GetToFileName(&fileName);
    fileNameStr = fileName;
  }

"fileNameStr = fileName;" will be fileNameStr.Assign(fileName).  So we should use Adopt, "nsXPIDLString fileNameStr", or AString parameter instead.

Comment 1

[Makoto Kato [:m_kato]]

Attachment: Bug 1263503 - memory leak of filename into layout/printing/nsPrintEngine.cpp.

"fileNameStr = fileName;" will be fileNameStr.Assign(fileName), so this causes small memory leak.  We should use Adopt, getter_copies, or AString parameter instead.

Review commit: https://reviewboard.mozilla.org/r/178140/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/178140/

Comment 2

[Mantaroh Yoshinaga[:mantaroh]]

Comment on attachment 8906425 [details]
Bug 1263503 - memory leak of filename into layout/printing/nsPrintEngine.cpp.

https://reviewboard.mozilla.org/r/178138/#review183098

Thanks!

Comment 3

[Mantaroh Yoshinaga[:mantaroh]]

Comment on attachment 8906425 [details]
Bug 1263503 - memory leak of filename into layout/printing/nsPrintEngine.cpp.

https://reviewboard.mozilla.org/r/178140/#review183102

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/5ea257c32084
memory leak of filename into layout/printing/nsPrintEngine.cpp. r=mantaroh

Comment 5

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/5ea257c32084

Comment 6

[Ryan VanderMeulen [:RyanVM]]

How severe is this leak? Is this something we should consider backporting to 56 or can it ride the 57 train?

Comment 7

[Makoto Kato [:m_kato]]

(In reply to Ryan VanderMeulen [:RyanVM] from comment #6)
> How severe is this leak? Is this something we should consider backporting to
> 56 or can it ride the 57 train?

This is small memory leak and this occurs when using [Print] - [Save as File].  Most users don't use this.

Comment 8

[Bob Owen (:bobowen)]

While I moved the pointer declaration in bug 1156742 (and should have spotted it :-) ), this leak has been there for over 15 years.