1263583 - [Mac] "Confirm Close" pop-up is shown even though "Show my windows and tabs from last time" is in effect

Status: RESOLVED INVALID

(Firefox :: Session Restore, defect)

Description

[Iulia Cristescu, QA [:JuliaC] (away, please needinfo? [e-mail])]

[Affected versions]:
- 48.0a1 (2016-04-10)
- 47.0a2 (2016-04-11)
- 46.0b9 build1 (20160407053945)
- 45.0.2 build1(20160407164938)
- 44.0 build3 (20160123151951)
- 43.0 build1 (20151208100201) 

[Affected platforms]:
- Mac OS X 10.11 
- Mac OS X 10.9

[Steps to reproduce]:
1. Launch Firefox with a clean profile.
2. Go to about:preferences.
3. On General tab, make sure that "When Firefox starts: Show my windows and tabs from last time" option is chosen in Startup section.
4. Open several random pages in different tabs.
5. Close Firefox by clicking the "X" button from the up-left window corner. 

[Expected result]:
- Firefox is properly closed without any multi-tab confirmation/warning message.

[Actual result]:
- The "Confirm Close" pop-up shows.

[Regression range]:
- I will check if this issue is a regression as soon as possible.

Comment 1

[Andrei Vaida [:avaida]]

[Tracking Requested - why for this release]:
Although this issue is reproducible on Fx45 (and likely on older versions as well) and we're late in the Fx46 beta cycle, I think this is an annoyingly enough bug to cause a medium/high impact on the user experience provided on Mac OS X.

Comment 2

[Iulia Cristescu, QA [:JuliaC] (away, please needinfo? [e-mail])]

I have also reproduced this issue on the same builds using Mac OS X 10.10.

Comment 3

[Jim Mathies [:jimm]]

Can you work up a regression window?

Comment 4

[Liz Henry (:lizzard Please n-i to RyanVM, jcristau, or pascal)]

I can track this (however briefly ) but it seems unlikely that we will fix this in time for 46. 

Is this really going to be an annoyance for users? It  isn't intuitive to me that checking the "offer to restore" option will then free me from the warning popup, and it doesn't sound like data loss either.

Comment 5

[Andrei Vaida [:avaida]]

(In reply to Liz Henry (:lizzard) (needinfo? me) from comment #4)
> I can track this (however briefly ) but it seems unlikely that we will fix
> this in time for 46. 
> 
> Is this really going to be an annoyance for users? It  isn't intuitive to me
> that checking the "offer to restore" option will then free me from the
> warning popup, and it doesn't sound like data loss either.

My understanding is that users perceive this dialog as a loss of all currently opened tabs -- which is expected if either "Show a blank page" or "Show my home page" is selected as a start-up option.

If users are being prompted with a "You are about to close X tabs [...]" message while "Show my windows and tabs from last time" is in effect, suggests that the current session won't be automatically restored the next time the browser is launched. I think that being prompted by this dialog no matter what option you set for when Firefox starts is confusing and has the potential of becoming increasingly annoying.

Comment 6

[Iulia Cristescu, QA [:JuliaC] (away, please needinfo? [e-mail])]

(In reply to Jim Mathies [:jimm] from comment #3)
> Can you work up a regression window?

I reproduced this issue on a wide range of Firefox builds, including Firefox 4.0. In conclusion, this bug isn`t a regression.

Comment 7

[Liz Henry (:lizzard Please n-i to RyanVM, jcristau, or pascal)]

OK. I don't think we need to track this then and I'll mark it wontfix for 46 and 47. 

Tim, what do you think about this? I notice you have fixed a lot of session restore bugs. Are you interested in looking at the Mac session restore/window closing state of things or can you suggest someone who might work on it? 

dolske what do you think? Andrei has a good point even if this isn't a regression it seems kind of annoying or alarming for mac users. Maybe this is something we should plan to fix.

Comment 8

[Justin Dolske [:Dolske]]

This seems expected to me. On OS X, closing an application's last window does not exit the app. This is unlike Windows, where clicking the "X" to close a window will also quit the app when it's the last window.

I'm pretty sure there are older bugs on a couple of related issues: exactly when to prompt about the "warn me when closing multiple tabs" pref, and how this all should interact with session restore... There are cases where, from session restore's perspective, you're closing windows and then quitting the app. So there's no session to restore (although I think you can still get at it through History -> Recently Closed Windows). But it's understandable how a user could want the next session to restore that window.