add options and private support to jsdIContext

RESOLVED FIXED in mozilla0.9.9

Status

Other Applications
Venkman JS Debugger
RESOLVED FIXED
16 years ago
14 years ago

People

(Reporter: Robert Ginda, Assigned: Robert Ginda)

Tracking

Trunk
mozilla0.9.9
x86
All

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

16 years ago
Patch adds read/write jsdIContext::options, and readonly
jsdIContext::privateData attributes.

Attempting to change the state of the JSOPTION_PRIVATE_IS_NSISUPPORTS causes an
error.
(Assignee)

Comment 1

16 years ago
patch coming up.
Status: NEW → ASSIGNED
Target Milestone: --- → mozilla0.9.9
(Assignee)

Comment 2

16 years ago
Created attachment 70249 [details] [diff] [review]
patch
(Assignee)

Comment 3

16 years ago
added ASSERT_VALID_EPHEMERAL to jsdContext::GetPrivateData.
Comment on attachment 70249 [details] [diff] [review]
patch

sr=jst
Attachment #70249 - Flags: superreview+

Comment 5

16 years ago
Comment on attachment 70249 [details] [diff] [review]
patch

r=jband. I'd like to see a comment added to the idl that notes that the OPT_
values line up with the #defines in the engine. When duplicate magic numbers
are unavoidable it is good to at least note that they are duplicates.
Attachment #70249 - Flags: review+
(Assignee)

Comment 6

16 years ago
checked in
Status: ASSIGNED → RESOLVED
Last Resolved: 16 years ago
Resolution: --- → FIXED
Product: Core → Other Applications
You need to log in before you can comment on or make changes to this bug.