Closed
Bug 126365
Opened 23 years ago
Closed 23 years ago
add options and private support to jsdIContext
Categories
(Other Applications Graveyard :: Venkman JS Debugger, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
mozilla0.9.9
People
(Reporter: rginda, Assigned: rginda)
Details
Attachments
(1 file)
|
2.80 KB,
patch
|
jband_mozilla
:
review+
jst
:
superreview+
|
Details | Diff | Splinter Review |
Patch adds read/write jsdIContext::options, and readonly jsdIContext::privateData attributes. Attempting to change the state of the JSOPTION_PRIVATE_IS_NSISUPPORTS causes an error.
|
Assignee | |
Comment 1•23 years ago
|
||
patch coming up.
Status: NEW → ASSIGNED
Target Milestone: --- → mozilla0.9.9
|
|
Assignee | |
Comment 2•23 years ago
|
||
|
|
Assignee | |
Comment 3•23 years ago
|
||
added ASSERT_VALID_EPHEMERAL to jsdContext::GetPrivateData.
|
||
Comment 4•23 years ago
|
||
Comment on attachment 70249 [details] [diff] [review] patch sr=jst
Attachment #70249 -
Flags: superreview+
|
||
Comment 5•23 years ago
|
||
Comment on attachment 70249 [details] [diff] [review] patch r=jband. I'd like to see a comment added to the idl that notes that the OPT_ values line up with the #defines in the engine. When duplicate magic numbers are unavoidable it is good to at least note that they are duplicates.
Attachment #70249 -
Flags: review+
|
|
Assignee | |
Comment 6•23 years ago
|
||
checked in
Status: ASSIGNED → RESOLVED
Closed: 23 years ago
Resolution: --- → FIXED
|
||
Updated•20 years ago
|
Product: Core → Other Applications
|
||
Updated•6 years ago
|
Product: Other Applications → Other Applications Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•