Closed Bug 1263660 Opened 8 years ago Closed 8 years ago

about:debugging does not warn when attempting to upload invalid WebExtension manifest

Categories

(DevTools :: about:debugging, defect)

Product:
DevTools
Component:
about:debugging
Version:
47 Branch
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED DUPLICATE of bug 1231128

People

(Reporter: cliabhach, Unassigned)

Details

User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_10_3) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/49.0.2623.110 Safari/537.36

Steps to reproduce:

Create a web extension with a manifest.json containing "manifest_version" property set to something other than 2.

Open Firefox Developer Edition.
Set about:config flag 'xpinstall.signatures.required' to false.
Click the 'Load Temporary Add-on' button on about:debugging.
Select the manifest.json file you created earlier.


Actual results:

The file selection window disappeared. That's it. Nothing else happened.


Expected results:

An error or popup (or something in the console) saying that Firefox only supports manifest_version 2 at this time.
Component: Untriaged → Developer Tools: about:debugging
I see it in Fx47.0a2 (2016-03-20), but WFM in 48.0a1 (2016-04-09) on Win10, a warning say: There was an error during installation: Extension is invalid.

Fixed in bug 1231128.
Status: UNCONFIRMED → RESOLVED
Closed: 8 years ago
Resolution: --- → DUPLICATE
Hi cliabhach, welcome to Bugzilla!

Thanks a lot for taking the time to log this bug. Your problem looks similar to bug 1231128, which was fixed recently, and adds an error message to about:debugging when 'Load Temporary Add-on' fails.

The fix landed in Firefox Nightly last week, so it will be available in the next Firefox Developer Edition, which releases in about 3 weeks from now.
Wow, sorry, I completely missed that one. Figures that my first bug report is a duplicate....
(In reply to cliabhach from comment #3)
> Wow, sorry, I completely missed that one. Figures that my first bug report
> is a duplicate....

Don't worry about it, it's better to file so the issue gets logged at least! :) It's easy to miss duplicate issues, and the team working on a component should be able to spot them quickly.
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.