Closed Bug 1263662 Opened 4 years ago Closed 4 years ago

No longer reporting size of omni.ja to perfherder

Categories

(Firefox Build System :: General, defect)

defect
Not set

Tracking

(firefox48 fixed)

RESOLVED FIXED
mozilla48
Tracking Status
firefox48 --- fixed

People

(Reporter: wlach, Assigned: gbrown)

References

Details

Attachments

(1 file)

After this set of pushes to fx-team, we're no longer reporting the omni.ja size to Perfherder, which changed the series signature.

https://hg.mozilla.org/integration/fx-team/pushloghtml?fromchange=9c04c66d849b&tochange=69f271e79c56

That is to say, while we used to printing something like the following in the logs:

15:20:07     INFO - PERFHERDER_DATA: {"framework": {"name": "build_metrics"}, "suites": [{"subtests": [{"name": "omni.ja", "value": 6014615}, {"name": "classes.dex", "value": 5041408}, {"name": "libxul.so", "value": 24902677}], "name": "installer size", "value": 39864438}, ...] }

We're now printing something like this:

15:20:07     INFO - PERFHERDER_DATA: {"framework": {"name": "build_metrics"}, "suites": [{"subtests": [{"name": "classes.dex", "value": 5041408}, {"name": "libxul.so", "value": 24902677}], "name": "installer size", "value": 39864438}, ...] }

I'm guessing this was due to one of the changes in either bug 1258450, bug 1258464, bug 1259507, or bug 1260241?
Flags: needinfo?(nalexander)
It could only be Bug 1260241.  At https://dxr.mozilla.org/mozilla-central/source/testing/mozharness/mozharness/mozilla/building/buildbase.py#1859, we're looking for stuff lying around the objdir; Bug 1260241 no longer makes these (needless) copies to dist/ and just uses stuff directly from the objdir.

The expedient answer is to re-instate these needless copies.  The next expedient answer is to use the stuff directly from the objdir.  That clearly shows how fragile this approach is.  What we should really do is sever minimize the link between buildbase.py and the objdir, and extract (or interrogate the sizes of) the files from the actual APK produced.  That is, the input to this function should just be the APK, not the whole objdir.

gbrown, I can't work on this.  Can you take this or redirect it?
Flags: needinfo?(nalexander) → needinfo?(gbrown)
Assignee: nobody → gbrown
Flags: needinfo?(gbrown)
Attached patch fix pathSplinter Review
The expedient solution -- fix the path.

I'll file another bug to follow-up on nalexander's suggestions.

https://treeherder.mozilla.org/#/jobs?repo=try&revision=f43718330df6
Attachment #8740165 - Flags: review?(wlachance)
Comment on attachment 8740165 [details] [diff] [review]
fix path

Review of attachment 8740165 [details] [diff] [review]:
-----------------------------------------------------------------

lgtm
Attachment #8740165 - Flags: review?(wlachance) → review+
https://hg.mozilla.org/mozilla-central/rev/5ab699cab543
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla48
Product: Core → Firefox Build System
You need to log in before you can comment on or make changes to this bug.