Improve defaultSearch core-ping docs for custom search engines

RESOLVED FIXED in Firefox 48

Status

()

Firefox for Android
General
RESOLVED FIXED
2 years ago
2 years ago

People

(Reporter: mcomella, Assigned: mcomella)

Tracking

unspecified
Firefox 48
All
Android
Points:
---

Firefox Tracking Flags

(firefox48 fixed)

Details

MozReview Requests

()

Submitter Diff Changes Open Issues Last Updated
Loading...
Error loading review requests:

Attachments

(1 attachment)

Comment hidden (empty)
Created attachment 8740168 [details]
MozReview Request: Bug 1263761 - Update defaultSearch in core ping docs for custom search engines. r=gfritzsche

Review commit: https://reviewboard.mozilla.org/r/45605/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/45605/
Attachment #8740168 - Flags: review?(gfritzsche)
Comment on attachment 8740168 [details]
MozReview Request: Bug 1263761 - Update defaultSearch in core ping docs for custom search engines. r=gfritzsche

https://reviewboard.mozilla.org/r/45605/#review42261

Thanks for keeping the docs up-to-date.

::: toolkit/components/telemetry/docs/core-ping.rst:81
(Diff revision 1)
> +This field can also be ``null`` when a custom search engine is set as the
> +default.

```
... is set as the default (`bug XXX <https:// ...>`_ will fix this).
```
Attachment #8740168 - Flags: review?(gfritzsche) → review+
https://reviewboard.mozilla.org/r/45605/#review42261

> ```
> ... is set as the default (`bug XXX <https:// ...>`_ will fix this).
> ```

This is actually intended to land after bug 1249288. See https://bugzilla.mozilla.org/show_bug.cgi?id=1249288#c75

I'm going to leave the comment the way it is.
https://hg.mozilla.org/integration/fx-team/rev/6c9c59550600d7523a7d58d23c1c9a6bce91b0f1
Bug 1263761 - Update defaultSearch in core ping docs for custom search engines. r=gfritzsche

Comment 5

2 years ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/6c9c59550600
Status: NEW → RESOLVED
Last Resolved: 2 years ago
status-firefox48: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 48
You need to log in before you can comment on or make changes to this bug.