Closed Bug 1263761 Opened 4 years ago Closed 4 years ago

Improve defaultSearch core-ping docs for custom search engines

Categories

(Firefox for Android :: General, defect)

All
Android
defect
Not set
normal

Tracking

()

RESOLVED FIXED
Firefox 48
Tracking Status
firefox48 --- fixed

People

(Reporter: mcomella, Assigned: mcomella)

References

Details

Attachments

(1 file)

No description provided.
Comment on attachment 8740168 [details]
MozReview Request: Bug 1263761 - Update defaultSearch in core ping docs for custom search engines. r=gfritzsche

https://reviewboard.mozilla.org/r/45605/#review42261

Thanks for keeping the docs up-to-date.

::: toolkit/components/telemetry/docs/core-ping.rst:81
(Diff revision 1)
> +This field can also be ``null`` when a custom search engine is set as the
> +default.

```
... is set as the default (`bug XXX <https:// ...>`_ will fix this).
```
Attachment #8740168 - Flags: review?(gfritzsche) → review+
https://reviewboard.mozilla.org/r/45605/#review42261

> ```
> ... is set as the default (`bug XXX <https:// ...>`_ will fix this).
> ```

This is actually intended to land after bug 1249288. See https://bugzilla.mozilla.org/show_bug.cgi?id=1249288#c75

I'm going to leave the comment the way it is.
https://hg.mozilla.org/mozilla-central/rev/6c9c59550600
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 48
You need to log in before you can comment on or make changes to this bug.