Make the external string API's Truncate compatible with the internal API's Truncate

RESOLVED FIXED in Firefox 48

Status

()

RESOLVED FIXED
2 years ago
2 years ago

People

(Reporter: jwatt, Assigned: jwatt)

Tracking

unspecified
mozilla48
Points:
---

Firefox Tracking Flags

(firefox48 fixed)

Details

Attachments

(1 attachment)

(Assignee)

Description

2 years ago
Can we make the external string API's Truncate compatible with the internal API's Truncate by adding a parameter with a default argument, or do we need strict ABI compatibility?
(Assignee)

Comment 1

2 years ago
Created attachment 8740179 [details] [diff] [review]
patch
Attachment #8740179 - Flags: review?(nfroyd)
Comment on attachment 8740179 [details] [diff] [review]
patch

Review of attachment 8740179 [details] [diff] [review]:
-----------------------------------------------------------------

This change seems reasonable, and I don't think we have a lot of concerns about binary compatibility at this point.
Attachment #8740179 - Flags: review?(nfroyd) → review+

Comment 4

2 years ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/b5600b3a7deb
Status: NEW → RESOLVED
Last Resolved: 2 years ago
status-firefox48: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla48
You need to log in before you can comment on or make changes to this bug.