Closed
Bug 1263777
Opened 9 years ago
Closed 9 years ago
Use WeakCache to sweep the InitialShapeTable
Categories
(Core :: JavaScript: GC, defect)
Core
JavaScript: GC
Tracking
()
RESOLVED
FIXED
mozilla48
| Tracking | Status | |
|---|---|---|
| firefox48 | --- | fixed |
People
(Reporter: terrence, Assigned: terrence)
References
Details
Attachments
(1 file)
|
9.08 KB,
patch
|
jonco
:
review+
|
Details | Diff | Splinter Review |
Continuing down the list.
Attachment #8740198 -
Flags: review?(jcoppeard)
|
||
Comment 1•9 years ago
|
||
Comment on attachment 8740198 [details] [diff] [review]
weakcache_InitialShapeTable-v0.diff
Review of attachment 8740198 [details] [diff] [review]:
-----------------------------------------------------------------
Nice simplification.
::: js/src/vm/Shape.cpp
@@ +1462,5 @@
> size_t nfixed, uint32_t objectFlags)
> {
> MOZ_ASSERT_IF(proto.isObject(), cx->isInsideCurrentCompartment(proto.toObject()));
>
> + InitialShapeSet& table = cx->compartment()->initialShapes.get();
WeakCache uses MutableGCHashMapOperations so can we just use auto& here and not worry about calling get()?
Attachment #8740198 -
Flags: review?(jcoppeard) → review+
|
Assignee | |
Comment 2•9 years ago
|
||
Comment on attachment 8740198 [details] [diff] [review]
weakcache_InitialShapeTable-v0.diff
Review of attachment 8740198 [details] [diff] [review]:
-----------------------------------------------------------------
::: js/src/jscompartment.cpp
@@ +1122,5 @@
> objectGroups.addSizeOfExcludingThis(mallocSizeOf, tiAllocationSiteTables,
> tiArrayTypeTables, tiObjectTypeTables,
> compartmentTables);
> *compartmentTables += baseShapes.get().sizeOfExcludingThis(mallocSizeOf)
> + + initialShapes.get().sizeOfExcludingThis(mallocSizeOf);
Fixed by passing throw the Ops.
::: js/src/vm/Shape.cpp
@@ +1462,5 @@
> size_t nfixed, uint32_t objectFlags)
> {
> MOZ_ASSERT_IF(proto.isObject(), cx->isInsideCurrentCompartment(proto.toObject()));
>
> + InitialShapeSet& table = cx->compartment()->initialShapes.get();
Done, and used MakeDependentAddPtr below.
|
|
Assignee | |
Comment 3•9 years ago
|
||
s/throw/through/
|
|
Assignee | |
Comment 4•9 years ago
|
||
|
|
Assignee | |
Comment 5•9 years ago
|
||
|
|
Assignee | |
Comment 6•9 years ago
|
||
|
|
Assignee | |
Comment 7•9 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/76e8f6ad9ded250863aabef2da248867bc96e79c
Bug 1263777 - Use WeakCache to sweep the InitialShapeTable; r=jonco
|
||
Comment 8•9 years ago
|
||
| bugherder | ||
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla48
You need to log in
before you can comment on or make changes to this bug.
Description
•