1263790 - Resource timing initiatorType should be "iframe" instead of "subdocument"

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect)

Comment 1

[Valentin Gosu [:valentin] {{ PTO 3 July - 3 August }}]

Attachment: Resource timing initiatorType should be "iframe" instead of "subdocument"

Comment 2

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 8740221 [details] [diff] [review]
Resource timing initiatorType should be "iframe" instead of "subdocument"

Won't this set initiatorType to "iframe" for a <frame> element, while per spec it should be "frame"?

Please add a corresponding test.

Comment 3

[Valentin Gosu [:valentin] {{ PTO 3 July - 3 August }}]

Attachment: Resource timing initiatorType should be "iframe" instead of "subdocument"

MozReview-Commit-ID: D262VzFMDCM

Comment 4

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 8740725 [details] [diff] [review]
Resource timing initiatorType should be "iframe" instead of "subdocument"

>+        nsContentUtils::ASCIIToLower(initType);

You shouldn't need this.  The case should be correct anyway.

Also, you don't want the tagName.  The spec says it should be the localName.  So like so:

  if (frameElement) {
    timedChannel->SetInitiatorType(frameElement->LocalName());
  }

r=me with that.  Thank you for adding the test, though it would be ever better if it were a web platform test, since this is not testing anything Gecko-specific.

Comment 5

[Valentin Gosu [:valentin] {{ PTO 3 July - 3 August }}]

https://hg.mozilla.org/integration/mozilla-inbound/rev/f43c0ea2c7c847ca361375164b3a4c58eb714426
Bug 1263790 - Resource timing initiatorType should be "iframe" instead of "subdocument" r=bz

Comment 6

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/f43c0ea2c7c8