Closed
Bug 1263790
Opened 8 years ago
Closed 8 years ago
Resource timing initiatorType should be "iframe" instead of "subdocument"
Categories
(Core :: DOM: Core & HTML, defect)
Core
DOM: Core & HTML
Tracking
()
RESOLVED
FIXED
mozilla48
Tracking | Status | |
---|---|---|
firefox48 | --- | fixed |
People
(Reporter: valentin, Assigned: valentin)
References
Details
(Whiteboard: btpp-active)
Attachments
(1 file, 1 obsolete file)
6.89 KB,
patch
|
bzbarsky
:
review+
|
Details | Diff | Splinter Review |
No description provided.
Assignee | ||
Comment 1•8 years ago
|
||
Attachment #8740221 -
Flags: review?(bzbarsky)
Comment 2•8 years ago
|
||
Comment on attachment 8740221 [details] [diff] [review] Resource timing initiatorType should be "iframe" instead of "subdocument" Won't this set initiatorType to "iframe" for a <frame> element, while per spec it should be "frame"? Please add a corresponding test.
Attachment #8740221 -
Flags: review?(bzbarsky) → review-
Updated•8 years ago
|
Whiteboard: btpp-active
Assignee | ||
Comment 3•8 years ago
|
||
MozReview-Commit-ID: D262VzFMDCM
Attachment #8740725 -
Flags: review?(bzbarsky)
Assignee | ||
Updated•8 years ago
|
Attachment #8740221 -
Attachment is obsolete: true
Comment 4•8 years ago
|
||
Comment on attachment 8740725 [details] [diff] [review] Resource timing initiatorType should be "iframe" instead of "subdocument" >+ nsContentUtils::ASCIIToLower(initType); You shouldn't need this. The case should be correct anyway. Also, you don't want the tagName. The spec says it should be the localName. So like so: if (frameElement) { timedChannel->SetInitiatorType(frameElement->LocalName()); } r=me with that. Thank you for adding the test, though it would be ever better if it were a web platform test, since this is not testing anything Gecko-specific.
Attachment #8740725 -
Flags: review?(bzbarsky) → review+
Assignee | ||
Comment 5•8 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/f43c0ea2c7c847ca361375164b3a4c58eb714426 Bug 1263790 - Resource timing initiatorType should be "iframe" instead of "subdocument" r=bz
Comment 6•8 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/f43c0ea2c7c8
Status: NEW → RESOLVED
Closed: 8 years ago
status-firefox48:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla48
Updated•5 years ago
|
Component: DOM → DOM: Core & HTML
You need to log in
before you can comment on or make changes to this bug.
Description
•