Support IPC for TV service between B2G and content process

RESOLVED FIXED

Status

Firefox OS
General
RESOLVED FIXED
2 years ago
2 years ago

People

(Reporter: kechen, Assigned: kechen)

Tracking

unspecified
ARM
Gonk (Firefox OS)

Firefox Tracking Flags

(blocking-b2g:2.6+, b2g-v2.6 fixed, b2g-master fixed)

Details

(Whiteboard: [ft:conndevices])

MozReview Requests

Submitter Diff Changes Open Issues Last Updated
Loading...
Error loading review requests:

Attachments

(3 attachments, 1 obsolete attachment)

(Assignee)

Description

2 years ago
Support IPC for TV service between B2G and content process.
(Assignee)

Comment 1

2 years ago
Created attachment 8740234 [details]
MozReview Request: Bug 1263799 - Support IPC for TV service between B2G and content processes. Part 3 - Enhance TV mochitests. r=schien

Review commit: https://reviewboard.mozilla.org/r/45661/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/45661/
Attachment #8740234 - Flags: review?(schien)
Attachment #8740235 - Flags: review?(schien)
(Assignee)

Comment 2

2 years ago
Created attachment 8740235 [details]
MozReview Request: Bug 1263799 - Support IPC for TV service between B2G and content processes. Part 2 - IPC. r?schien

Review commit: https://reviewboard.mozilla.org/r/45663/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/45663/
(Assignee)

Comment 3

2 years ago
Comment on attachment 8740234 [details]
MozReview Request: Bug 1263799 - Support IPC for TV service between B2G and content processes. Part 3 - Enhance TV mochitests. r=schien

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/45661/diff/1-2/
Attachment #8740234 - Attachment description: MozReview Request: Bug 1263799 - Support IPC for TV service between B2G and content processes. Part 1 - Refactor TV service and pass TV stream handle. r?schien → MozReview Request: Bug 1263799 - Support IPC for TV service between B2G and content processes. Part 3 - Enhance TV mochitests. r?schien
(Assignee)

Updated

2 years ago
Attachment #8740235 - Attachment is obsolete: true
Attachment #8740235 - Flags: review?(schien)
(Assignee)

Comment 4

2 years ago
Created attachment 8740829 [details]
MozReview Request: Bug 1263799 - Support IPC for TV service between B2G and content processes. Part 1 - Refactor TV service and pass TV stream handle. r=schien

Review commit: https://reviewboard.mozilla.org/r/46035/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/46035/
Attachment #8740829 - Flags: review?(schien)
Attachment #8740830 - Flags: review?(schien)
(Assignee)

Comment 5

2 years ago
Created attachment 8740830 [details]
MozReview Request: Bug 1263799 - Support IPC for TV service between B2G and content processes. Part 2 - IPC. r=schien

Review commit: https://reviewboard.mozilla.org/r/46037/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/46037/
(Assignee)

Comment 6

2 years ago
Comment on attachment 8740234 [details]
MozReview Request: Bug 1263799 - Support IPC for TV service between B2G and content processes. Part 3 - Enhance TV mochitests. r=schien

For this patch, I've tried to observe the change of preference "dom.testing.tv_mock_data" to update the data in TVSimulatorService instead of add another test-only interface.
However, because TVSimulatorService is now in chrome process, the act after changing preference in content process cannot be sync with act of updating data from changed preference, I leave initData function to update data in TVSimulatorServer.
Comment on attachment 8740234 [details]
MozReview Request: Bug 1263799 - Support IPC for TV service between B2G and content processes. Part 3 - Enhance TV mochitests. r=schien

https://reviewboard.mozilla.org/r/45661/#review42937

::: dom/tv/TVSimulatorService.js:414
(Diff revision 2)
>    },
>  
> +  simulateChannelScanned: function(aTunerId, aSourceType) {
> +    let wrapTunerData = this._getWrapTunerData(aTunerId, aSourceType);
> +    if (!wrapTunerData || !wrapTunerData.channels) {
> +      return Cr.NS_ERROR_INVALID_ARG;

use |throw| instead of return.

::: dom/tv/TVSimulatorService.js:424
(Diff revision 2)
> +      for (let listener of listeners) {
> +        listener.notifyChannelScanned(aTunerId, aSourceType, wrapChannelData.channel);
> +      }
> +    }
> +
> +    return Cr.NS_OK;

don't need |return Cr.NS_OK|.
Attachment #8740234 - Flags: review?(schien)
Comment on attachment 8740830 [details]
MozReview Request: Bug 1263799 - Support IPC for TV service between B2G and content processes. Part 2 - IPC. r=schien

https://reviewboard.mozilla.org/r/46037/#review42547

::: dom/ipc/ContentChild.cpp:186
(Diff revision 1)
>  #include "mozilla/dom/bluetooth/PBluetoothChild.h"
>  #include "mozilla/dom/PFMRadioChild.h"
>  #include "mozilla/dom/PPresentationChild.h"
>  #include "mozilla/dom/PresentationIPCService.h"
>  #include "mozilla/ipc/InputStreamUtils.h"
> +#include "mozilla/dom/PTVChild.h"

nit: sort header file.

::: dom/tv/TVTypes.h:13
(Diff revision 1)
>  #define mozilla_dom_TVTypes_h
>  
>  #include "mozilla/layers/GonkNativeHandle.h"
>  #include "mozilla/Tuple.h"
>  #include "nsITVService.h"
> +#include "mozilla/dom/PTVTypes.h"

nit: sort header file

::: dom/tv/ipc/PTVTypes.ipdlh:1
(Diff revision 1)
> +using struct mozilla::layers::GonkNativeHandle from "mozilla/layers/GonkNativeHandleUtils.h";

nit: add modeline and license at the beginning.

::: dom/tv/ipc/TVChild.h:28
(Diff revision 1)
> +  virtual PTVRequestChild* AllocPTVRequestChild(const TVIPCRequest& aRequest)
> +    override;

nit: new line after |virtual PTVRequestChild*|

::: dom/tv/ipc/TVChild.h:33
(Diff revision 1)
> +  virtual bool RecvNotifyChannelScanned(
> +    const nsString& aTunerId, const nsString& aSourceType,
> +    const TVIPCChannelData& aChannelData) override;

nit: I prefer following format (here and elsewhere)

virtual bool
RecevNotifyChannelScanned(const ...,
                          const ...,
                          const ...) override;

::: dom/tv/ipc/TVChild.h:49
(Diff revision 1)
> +    const nsString& aTunerId, const nsString& aSourceType,
> +    const TVIPCChannelData& aChannelData,
> +    nsTArray<TVIPCProgramData>&& aProgramDataList) override;
> +
> +private:
> +  ~TVChild();

virtual

::: dom/tv/ipc/TVChild.cpp:8
(Diff revision 1)
> +/* This Source Code Form is subject to the terms of the Mozilla Public
> + * License, v. 2.0. If a copy of the MPL was not distributed with this file,
> + * You can obtain one at http://mozilla.org/MPL/2.0/. */
> +
> +#include "nsIMutableArray.h"
> +#include "TVChild.h"

#include "TVChild.h" should be the first.

::: dom/tv/ipc/TVChild.cpp:14
(Diff revision 1)
> +using namespace mozilla;
> +using namespace mozilla::dom;

replaced with

namespace mozilla {
namespace dom {

...

} // namespace dom
} // namespace mozilla

::: dom/tv/ipc/TVChild.cpp:187
(Diff revision 1)
> +      break;
> +    default:
> +      MOZ_CRASH("Unknown TVIPCResponse type");
> +  }
> +
> +  return NS_WARN_IF(NS_FAILED(rv)) ? false : true;

always return true here

::: dom/tv/ipc/TVIPCHelper.h:10
(Diff revision 1)
> +#include "nsITVService.h"
> +#include "mozilla/dom/PTVTypes.h"

sort header file

::: dom/tv/ipc/TVIPCHelper.cpp:20
(Diff revision 1)
> +  nsAutoString id;
> +  uint16_t streamType;
> +  uint32_t sourceTypeCount;
> +  nsTArray<nsCString> sourceTypes;

move the declaration to where it is used, here and elsewhere.

::: dom/tv/ipc/TVIPCHelper.cpp:67
(Diff revision 1)
> +  nsString serviceId;
> +  nsString type;
> +  nsString number;
> +  nsString name;
> +
> +  if (aChannelData == nullptr) {

use |if (!xxx)| here and elsewhere.

::: dom/tv/ipc/TVIPCHelper.cpp:86
(Diff revision 1)
> +  aIPCChannelData.number() = NS_ConvertUTF16toUTF8(number);
> +  aChannelData->GetName(name);
> +  aIPCChannelData.name() = NS_ConvertUTF16toUTF8(name);
> +  aChannelData->GetIsEmergency(&aIPCChannelData.isEmergency());
> +  aChannelData->GetIsFree(&aIPCChannelData.isFree());
> +  return;

remove |return;| here and elsewhere.

::: dom/tv/ipc/TVIPCService.h:15
(Diff revision 1)
> +namespace mozilla
> +{
> +namespace dom
> +{

nit: no new line before '{'

::: dom/tv/ipc/TVIPCService.cpp:9
(Diff revision 1)
> + * License, v. 2.0. If a copy of the MPL was not distributed with this file,
> + * You can obtain one at http://mozilla.org/MPL/2.0/. */
> +
> +#include "mozilla/dom/ContentChild.h"
> +#include "TVChild.h"
> +#include "TVIPCService.h"

#include "TVIPCService.h" should be the first.

::: dom/tv/ipc/TVIPCService.cpp:17
(Diff revision 1)
> +using namespace mozilla::dom;
> +
> +namespace
> +{
> +
> +TVChild* sTVChild;

use static StaticAutoPtr<TVChild> here and remove the anonymous space.

::: dom/tv/ipc/TVIPCService.cpp:34
(Diff revision 1)
> +  sTVChild = new TVChild(this);
> +  NS_WARN_IF(!contentChild->SendPTVConstructor(sTVChild));
> +}
> +
> +/* virtual */
> +TVIPCService::~TVIPCService() { sTVChild = nullptr; }

nit: new line after '{' and '}'

::: dom/tv/ipc/TVIPCService.cpp:87
(Diff revision 1)
> +}
> +
> +void
> +TVIPCService::GetSourceListeners(
> +  const nsAString& aTunerId, const nsAString& aSourceType,
> +  nsTArray<nsCOMPtr<nsITVSourceListener>>& aListeners) const

nit: new line for |const nsAString& aSourceType,|

::: dom/tv/ipc/TVIPCService.cpp:115
(Diff revision 1)
> +  return SendRequest(aCallback, TVGetTunersRequest());
> +}
> +
> +/* virtual */ NS_IMETHODIMP
> +TVIPCService::SetSource(const nsAString& aTunerId, const nsAString& aSourceType,
> +                        nsITVServiceCallback* aCallback)

nit: new line for |const nsAString& aSourceType,|

::: dom/tv/ipc/TVIPCService.cpp:198
(Diff revision 1)
> +    return NS_ERROR_INVALID_ARG;
> +  }
> +
> +  return SendRequest(
> +    aCallback,
> +    TVGetChannelsRequest(nsAutoString(aTunerId), nsAutoString(aSourceType)));

nit: use the format like in line 179

::: dom/tv/ipc/TVParent.h:18
(Diff revision 1)
> +#include "nsITVService.h"
> +
> +namespace mozilla {
> +namespace dom {
> +
> +class TVParent final : public PTVParent, public nsITVSourceListener

nit: put base class in each line, here and elsewhere

::: dom/tv/ipc/TVParent.cpp:75
(Diff revision 1)
> +      break;
> +    default:
> +      MOZ_CRASH("Unknown TVIPCRequest type");
> +  }
> +
> +  return !NS_WARN_IF(NS_FAILED(rv));

always return true here.

::: dom/tv/ipc/TVParent.cpp:241
(Diff revision 1)
> +  }
> +
> +  NS_IMETHOD NotifySuccess(nsIArray* aDataList) override;
> +
> +private:
> +  ~TVRequestTunerGetterCallback() {}

add |virtual| here and else where to make it more explicit.

::: dom/tv/ipc/TVParent.cpp:379
(Diff revision 1)
> +  }
> +
> +  TVIPCChannelData ipcChannelData;
> +
> +  PackTVIPCChannelData(channelData, ipcChannelData);
> +  rv = mRequestParent->SendResponse(TVSetChannelResponse(ipcChannelData));

check if mRequestParent is available before use it, or MOZ_ASSERT(mRequestParent).

::: dom/tv/moz.build:11
(Diff revision 1)
>  
>  EXPORTS.mozilla.dom += [
> +    'ipc/TVChild.h',
> +    'ipc/TVIPCHelper.h',
> +    'ipc/TVIPCService.h',
> +    'ipc/TVParent.h',

these header file are not included in files out side of dom/tv. no need to export.

::: dom/tv/nsITVService.idl:132
(Diff revision 1)
>     */
>    void getAudioLanguages([optional] out unsigned long count,
>                           [retval, array, size_is(count)] out string languages);
>  
> +  void getAudioLanguagesByString([optional] out unsigned long count,
> +                                 out CStringArray languages);

can we do |CStringArray getAudioLanguagesByString(...)|?
Comment on attachment 8740829 [details]
MozReview Request: Bug 1263799 - Support IPC for TV service between B2G and content processes. Part 1 - Refactor TV service and pass TV stream handle. r=schien

https://reviewboard.mozilla.org/r/46035/#review42541

::: dom/tv/TVListeners.cpp:46
(Diff revision 1)
> -void
> -TVSourceListener::UnregisterSource(TVSource* aSource)
> +TVSourceListener::TVSourceListener(TVSource* aSource) : mSource(aSource)
> +{
> +  MOZ_ASSERT(mSource);
> +}
> +
> +TVSourceListener::~TVSourceListener() { Shutdown(); }

nit: new line before '{' and '}'.

::: dom/tv/TVServiceFactory.cpp:28
(Diff revision 1)
>  
> -  rv = service->SetSourceListener(new TVSourceListener());
> -  if (NS_WARN_IF(NS_FAILED(rv))) {
> -    return nullptr;
> +#ifdef MOZ_WIDGET_GONK
> +  service = new TVGonkService();
> +#endif
> +
> +  if (service == nullptr) {

if(!service)

::: dom/tv/TVSimulatorService.js:225
(Diff revision 1)
> +
> +    if (listeners.indexOf(aListener) < 0) {
> +      listeners.push(aListener);
> +    }
> +
> +    return Cr.NS_OK;

no need to return Cr.NS_OK.
(Assignee)

Comment 10

2 years ago
Comment on attachment 8740829 [details]
MozReview Request: Bug 1263799 - Support IPC for TV service between B2G and content processes. Part 1 - Refactor TV service and pass TV stream handle. r=schien

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/46035/diff/1-2/
Attachment #8740829 - Flags: review?(schien)
Attachment #8740830 - Flags: review?(schien)
Attachment #8740234 - Flags: review?(schien)
(Assignee)

Comment 11

2 years ago
Comment on attachment 8740830 [details]
MozReview Request: Bug 1263799 - Support IPC for TV service between B2G and content processes. Part 2 - IPC. r=schien

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/46037/diff/1-2/
(Assignee)

Comment 12

2 years ago
Comment on attachment 8740234 [details]
MozReview Request: Bug 1263799 - Support IPC for TV service between B2G and content processes. Part 3 - Enhance TV mochitests. r=schien

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/45661/diff/2-3/
Comment on attachment 8740829 [details]
MozReview Request: Bug 1263799 - Support IPC for TV service between B2G and content processes. Part 1 - Refactor TV service and pass TV stream handle. r=schien

https://reviewboard.mozilla.org/r/46035/#review43607

r+ with my comments addressed.

::: dom/tv/TVSimulatorService.js:272
(Diff revisions 1 - 2)
> -    return aCallback.notifySuccess(tuners);
> +    try {
> +      aCallback.notifySuccess(tuners);
> +    } catch(e) {
> +      throw e;
> +    }

This modification is not necessary, you don't need to catch & re-throw the same exception.

::: layout/build/nsLayoutModule.cpp:399
(Diff revisions 1 - 2)
>  NS_GENERIC_FACTORY_SINGLETON_CONSTRUCTOR(nsITelephonyService,
>                                           NS_CreateTelephonyService)
>  NS_GENERIC_FACTORY_SINGLETON_CONSTRUCTOR(nsIVoicemailService,
>                                           NS_CreateVoicemailService)
>  NS_GENERIC_FACTORY_SINGLETON_CONSTRUCTOR(nsITVService,
> -                                         TVServiceFactory::AutoCreateTVService)
> +                                         TVServiceFactory::AutoCreateTVService) 

nit: remove trailing space.
Attachment #8740829 - Flags: review?(schien) → review+
Comment on attachment 8740830 [details]
MozReview Request: Bug 1263799 - Support IPC for TV service between B2G and content processes. Part 2 - IPC. r=schien

https://reviewboard.mozilla.org/r/46037/#review43609

r+ with my comments addressed.

::: dom/tv/ipc/TVIPCHelper.cpp:54
(Diff revisions 1 - 2)
>    nsString networkId;
>    nsString transportStreamId;
>    nsString serviceId;
>    nsString type;
>    nsString number;
>    nsString name;
>  
> -  if (aChannelData == nullptr) {
> -    return;
> -  }
> -
>    aChannelData->GetNetworkId(networkId);
>    aIPCChannelData.networkId() = NS_ConvertUTF16toUTF8(networkId);
>    aChannelData->GetTransportStreamId(transportStreamId);
>    aIPCChannelData.transportStreamId() =
>      NS_ConvertUTF16toUTF8(transportStreamId);
>    aChannelData->GetServiceId(serviceId);
>    aIPCChannelData.serviceId() = NS_ConvertUTF16toUTF8(serviceId);
>    aChannelData->GetType(type);
>    aIPCChannelData.type() = NS_ConvertUTF16toUTF8(type);
>    aChannelData->GetNumber(number);
>    aIPCChannelData.number() = NS_ConvertUTF16toUTF8(number);
>    aChannelData->GetName(name);
>    aIPCChannelData.name() = NS_ConvertUTF16toUTF8(name);
>    aChannelData->GetIsEmergency(&aIPCChannelData.isEmergency());
>    aChannelData->GetIsFree(&aIPCChannelData.isFree());

nsAutoString networkId;
aChannelData->GetNetworkId(networkId);
aIPChannelData.networkId() = ...

nsAutoString transportStreamId;
aChannelData->GetTransportStreamId(transportStreamId);
aIPCChannelData.transportStreamId() = ...

...

::: dom/tv/ipc/TVParent.cpp:13
(Diff revisions 1 - 2)
> +
>  #include "mozilla/unused.h"
>  #include "TVTypes.h"
>  #include "TVIPCHelper.h"
>  
> +using namespace mozilla;

This line is not necessary

::: dom/tv/nsITVService.idl:53
(Diff revisions 1 - 2)
>     * @param sourceTypes An array of supported source types.
>     */
>    void getSupportedSourceTypes([optional] out unsigned long count,
>                                 [retval, array, size_is(count)] out string sourceTypes);
>  
> -  void getSupportedSourceTypesByString([optional] out unsigned long count,
> +  CStringArray getSupportedSourceTypesByString();

add [noscript] since this can only be used in C++.
Attachment #8740830 - Flags: review?(schien) → review+
Comment on attachment 8740234 [details]
MozReview Request: Bug 1263799 - Support IPC for TV service between B2G and content processes. Part 3 - Enhance TV mochitests. r=schien

https://reviewboard.mozilla.org/r/45661/#review43613

::: dom/tv/nsITVSimulatorService.idl:15
(Diff revision 3)
>  %{C++
>  #define TV_SIMULATOR_SERVICE_CONTRACTID\
>    "@mozilla.org/tv/simulatorservice;1"
>  %}
>  
> -[scriptable, uuid(3f670994-5915-415a-b906-7ead54bb3be1)]
> +[scriptable, uuid(8ecae67d-a959-4f8a-a786-14dc12bd8d3c)]

no need to change uuid anymore
Attachment #8740234 - Flags: review?(schien) → review+
(Assignee)

Updated

2 years ago
Assignee: nobody → kechen
(Assignee)

Comment 16

2 years ago
Comment on attachment 8740829 [details]
MozReview Request: Bug 1263799 - Support IPC for TV service between B2G and content processes. Part 1 - Refactor TV service and pass TV stream handle. r=schien

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/46035/diff/2-3/
Attachment #8740829 - Attachment description: MozReview Request: Bug 1263799 - Support IPC for TV service between B2G and content processes. Part 1 - Refactor TV service and pass TV stream handle. r?schien → MozReview Request: Bug 1263799 - Support IPC for TV service between B2G and content processes. Part 1 - Refactor TV service and pass TV stream handle. r=schien
Attachment #8740234 - Attachment description: MozReview Request: Bug 1263799 - Support IPC for TV service between B2G and content processes. Part 3 - Enhance TV mochitests. r?schien → MozReview Request: Bug 1263799 - Support IPC for TV service between B2G and content processes. Part 3 - Enhance TV mochitests. r=schien
(Assignee)

Comment 17

2 years ago
Comment on attachment 8740830 [details]
MozReview Request: Bug 1263799 - Support IPC for TV service between B2G and content processes. Part 2 - IPC. r=schien

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/46037/diff/2-3/
(Assignee)

Comment 18

2 years ago
Comment on attachment 8740234 [details]
MozReview Request: Bug 1263799 - Support IPC for TV service between B2G and content processes. Part 3 - Enhance TV mochitests. r=schien

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/45661/diff/3-4/
(Assignee)

Comment 19

2 years ago
Comment on attachment 8740829 [details]
MozReview Request: Bug 1263799 - Support IPC for TV service between B2G and content processes. Part 1 - Refactor TV service and pass TV stream handle. r=schien

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/46035/diff/3-4/
Attachment #8740830 - Attachment description: MozReview Request: Bug 1263799 - Support IPC for TV service between B2G and content processes. Part 2 - IPC. r?schien → MozReview Request: Bug 1263799 - Support IPC for TV service between B2G and content processes. Part 2 - IPC. r=schien
(Assignee)

Comment 20

2 years ago
Comment on attachment 8740830 [details]
MozReview Request: Bug 1263799 - Support IPC for TV service between B2G and content processes. Part 2 - IPC. r=schien

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/46037/diff/3-4/
(Assignee)

Comment 21

2 years ago
Comment on attachment 8740234 [details]
MozReview Request: Bug 1263799 - Support IPC for TV service between B2G and content processes. Part 3 - Enhance TV mochitests. r=schien

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/45661/diff/4-5/
(Assignee)

Comment 22

2 years ago
The following is the try result :
https://treeherder.mozilla.org/#/jobs?repo=try&revision=aa1199ee14e9&selectedJob=20031688

There are some failed tests, but these tests are not caused by these patches.
(Assignee)

Updated

2 years ago
Keywords: checkin-needed
(Assignee)

Updated

2 years ago
Keywords: checkin-needed
(Assignee)

Updated

2 years ago
Keywords: checkin-needed
(Assignee)

Comment 25

2 years ago
Hi Kit,

These patches will just land to B2G v2.6.
Thank you.
Flags: needinfo?(kechen)
(Assignee)

Comment 26

2 years ago
I will request for B2G 2.6 check in after testing on it.
(Assignee)

Comment 27

2 years ago
Comment on attachment 8740234 [details]
MozReview Request: Bug 1263799 - Support IPC for TV service between B2G and content processes. Part 3 - Enhance TV mochitests. r=schien

[Approval Request Comment]
Bug caused by (feature/regressing bug #):
https://bugzilla.mozilla.org/show_bug.cgi?id=1193239

User impact if declined: 
No impact in current feature, but it is necessary if anyone want to access TV-related components through Gecko.

Testing completed:
There are some errors but they are not caused by this patch.
https://treeherder.mozilla.org/#/jobs?repo=try&revision=363007e3685b&filter-tier=1&filter-tier=2&filter-tier=3&selectedJob=20540827

Risk to taking this patch (and alternatives if risky):
If the patch causes crash, it may break the code which use TV manager API.

String or UUID changes made by this patch: None
Attachment #8740234 - Flags: approval-mozilla-b2g48?
(Assignee)

Comment 28

2 years ago
Comment on attachment 8740829 [details]
MozReview Request: Bug 1263799 - Support IPC for TV service between B2G and content processes. Part 1 - Refactor TV service and pass TV stream handle. r=schien

NOTE: Please see https://wiki.mozilla.org/Release_Management/B2G_Landing to better understand the B2G approval process and landings.

[Approval Request Comment]
Bug caused by (feature/regressing bug #): 
User impact if declined: 
Testing completed: 
Risk to taking this patch (and alternatives if risky): 
String or UUID changes made by this patch:

[Approval Request Comment]
Bug caused by (feature/regressing bug #):
https://bugzilla.mozilla.org/show_bug.cgi?id=1193239

User impact if declined: 
No impact in current feature, but it is necessary if anyone want to access TV-related components through Gecko.

Testing completed:
There are some errors but they are not caused by this patch.
https://treeherder.mozilla.org/#/jobs?repo=try&revision=363007e3685b&filter-tier=1&filter-tier=2&filter-tier=3&selectedJob=20540827

Risk to taking this patch (and alternatives if risky):
If the patch causes crash, it may break the code which use TV manager API.

String or UUID changes made by this patch: None
Attachment #8740829 - Flags: approval-mozilla-b2g48?
(Assignee)

Comment 29

2 years ago
Comment on attachment 8740830 [details]
MozReview Request: Bug 1263799 - Support IPC for TV service between B2G and content processes. Part 2 - IPC. r=schien

NOTE: Please see https://wiki.mozilla.org/Release_Management/B2G_Landing to better understand the B2G approval process and landings.

[Approval Request Comment]
Bug caused by (feature/regressing bug #): 
User impact if declined: 
Testing completed: 
Risk to taking this patch (and alternatives if risky): 
String or UUID changes made by this patch:
Attachment #8740830 - Flags: approval-mozilla-b2g48?

Comment 30

2 years ago
Comment on attachment 8740234 [details]
MozReview Request: Bug 1263799 - Support IPC for TV service between B2G and content processes. Part 3 - Enhance TV mochitests. r=schien

Approve for TV 2.6
Attachment #8740234 - Flags: approval-mozilla-b2g48? → approval-mozilla-b2g48+

Comment 31

2 years ago
Comment on attachment 8740829 [details]
MozReview Request: Bug 1263799 - Support IPC for TV service between B2G and content processes. Part 1 - Refactor TV service and pass TV stream handle. r=schien

Approve for TV 2.6
Attachment #8740829 - Flags: approval-mozilla-b2g48? → approval-mozilla-b2g48+

Comment 32

2 years ago
Comment on attachment 8740830 [details]
MozReview Request: Bug 1263799 - Support IPC for TV service between B2G and content processes. Part 2 - IPC. r=schien

Approve for TV 2.6
Attachment #8740830 - Flags: approval-mozilla-b2g48? → approval-mozilla-b2g48+

Updated

2 years ago
blocking-b2g: --- → 2.6+
status-b2g-master: --- → fixed
Whiteboard: [ft:conndevices]
rebase neeeded
Flags: needinfo?(kechen)
https://github.com/mozilla-b2g/gecko-b2g/commit/113bb2fe104464c36fc7fd548a0c5ca724c06f66
Status: NEW → RESOLVED
Last Resolved: 2 years ago
status-b2g-v2.6: --- → fixed
Flags: needinfo?(kechen)
Resolution: --- → FIXED
(Assignee)

Updated

2 years ago
Duplicate of this bug: 1229301
You need to log in before you can comment on or make changes to this bug.