Closed Bug 1263804 Opened 3 years ago Closed 3 years ago

Remove last references to Metrics.jsm

Categories

(Firefox :: General, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
Firefox 48
Tracking Status
firefox48 --- fixed

People

(Reporter: Unfocused, Assigned: Unfocused)

References

Details

Attachments

(1 file)

Bug 1235345 removed services/metrics, but seems to have missed a couple of references to Metrics.jsm - which didn't break because they're in unused lazy getters.
Assignee: nobody → bmcbride
Status: NEW → ASSIGNED
Attached patch Patch v1Splinter Review
Attachment #8740238 - Flags: review?(gijskruitbosch+bugs)
Comment on attachment 8740238 [details] [diff] [review]
Patch v1

Review of attachment 8740238 [details] [diff] [review]:
-----------------------------------------------------------------

r=me

Should https://dxr.mozilla.org/mozilla-central/source/toolkit/components/telemetry/docs/fhr/architecture.rst#11 get updated as well?
Attachment #8740238 - Flags: review?(gijskruitbosch+bugs) → review+
(In reply to :Gijs Kruitbosch from comment #2)
> Should
> https://dxr.mozilla.org/mozilla-central/source/toolkit/components/telemetry/
> docs/fhr/architecture.rst#11 get updated as well?

I'm going to assume not - it's not just that line, but that entire directory that needs removed (since FHR itself was removed in bug 1234526). index.rst in that directory includes the following:

> **Firefox Health Report (FHR) is obsolete and no longer ships with Firefox.
> This documentation will live here for a few more cycles.**
https://hg.mozilla.org/mozilla-central/rev/543033638027
Status: ASSIGNED → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 48
You need to log in before you can comment on or make changes to this bug.