1263849 - Reorganize the graphics section in about:support

Status: VERIFIED FIXED

(Core :: Graphics, defect)

Description

[David Anderson [:dvander] - inactive, e-mail if emergency]

I'd like to extend the graphics section of about:support with interesting bits from gfxConfig. This section is rather unorganized at the moment so it's hard to see where to put it.

Comment 1

[David Anderson [:dvander] - inactive, e-mail if emergency]

Attachment: patch

This patch divides the table into a few sub-sections: Features, GPUs, Diagnostics, and Failures. It's kind of arbitrary so other suggestions are welcome. It also hardcodes the sorting so we can compare localized versions much easier.

Two side effects of this approach are: the graphics section takes up more vertical space, and properties will no longer magically show up by being added to Troubleshooting.jsm. They have to be explicitly appended somewhere in aboutSupport.js.

Comment 2

[David Anderson [:dvander] - inactive, e-mail if emergency]

Attachment: patch v2

Comment 3

[David Anderson [:dvander] - inactive, e-mail if emergency]

Attachment: screenshot

This is a screenshot of the new about:support section, with a fake critical note injected.

Comment 4

[Kartikaya Gupta (email:[e-mail])]

During a discussion the other day it came up that it would also be useful to have the max texture size and the tile size reported in about:support. We can do it in a different bug if it doesn't make sense as part of this one.

Comment 5

[Milan Sreckovic [:milan] (needinfo for best results)]

Probably a different bug - it would be good if this one only covered the reorganization of exactly the data we get today.

Comment 6

[Milan Sreckovic [:milan] (needinfo for best results)]

Didn't look at the code yet, but with this patch I'm missing Vendor and Device ID and "windowLayerManagerRemote" entries.

Comment 7

[David Anderson [:dvander] - inactive, e-mail if emergency]

(In reply to Milan Sreckovic [:milan] from comment #6)
> Didn't look at the code yet, but with this patch I'm missing Vendor and
> Device ID and "windowLayerManagerRemote" entries.

You should unconditionally get Vendor/Device ID under the GPU #1 section, so that's odd... can you screenshot?

I took windowLayerManagerRemote out as its own column. If it's false, the "Compositing" field will show "BasicLayers" now instead.

Comment 8

[Milan Sreckovic [:milan] (needinfo for best results)]

Attachment: With the patch above, on OS X.

Comment 9

[Milan Sreckovic [:milan] (needinfo for best results)]

(In reply to David Anderson [:dvander] from comment #7)
> (In reply to Milan Sreckovic [:milan] from comment #6)
> > Didn't look at the code yet, but with this patch I'm missing Vendor and
> > Device ID and "windowLayerManagerRemote" entries.
> 
> You should unconditionally get Vendor/Device ID under the GPU #1 section, so
> that's odd... can you screenshot?
> 
> I took windowLayerManagerRemote out as its own column. If it's false, the
> "Compositing" field will show "BasicLayers" now instead.

I don't get the GPU#1 section :)

Comment 10

[Milan Sreckovic [:milan] (needinfo for best results)]

No console errors.

Comment 11

[David Anderson [:dvander] - inactive, e-mail if emergency]

Whoops, yeah that's very broken. I'll check things on Mac/Linux.

Comment 12

[Milan Sreckovic [:milan] (needinfo for best results)]

Attachment: With the patch above, don't style.display = none the empty sections

Comment 13

[Milan Sreckovic [:milan] (needinfo for best results)]

(In reply to David Anderson [:dvander] from comment #1)
> ... and properties will no longer magically show up by being
> added to Troubleshooting.jsm. They have to be explicitly appended somewhere
> in aboutSupport.js.

I'd really like to keep this "feature" - if something unknown shows up, we display it.  Even if it means having an "other" section.  I understand it is accomplished today by removing things we understand, and display "whatever's left", and unless that approach has really bad performance implications, it feels like it's worth keeping.

Comment 14

[Milan Sreckovic [:milan] (needinfo for best results)]

(In reply to Milan Sreckovic [:milan] from comment #13)
> (In reply to David Anderson [:dvander] from comment #1)
> > ... and properties will no longer magically show up by being
> > added to Troubleshooting.jsm. They have to be explicitly appended somewhere
> > in aboutSupport.js.
> 
> I'd really like to keep this "feature" - if something unknown shows up, we
> display it.  Even if it means having an "other" section.  I understand it is
> accomplished today by removing things we understand, and display "whatever's
> left", and unless that approach has really bad performance implications, it
> feels like it's worth keeping.

I'm fine if this is done in a followup bug.

Comment 15

[David Anderson [:dvander] - inactive, e-mail if emergency]

Attachment: patch v3

This version fixes the issues on OS X/Linux. The bug was that adapters with missing descriptions were considered bogus.

I re-added showing implicit data properties in the table, under the "Diagnostics" section. The code to delete explicitly chosen fields is back.

Comment 16

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/efaa8959220e

Comment 17

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/8ed07c4d0e3e

Comment 18

[David Anderson [:dvander] - inactive, e-mail if emergency]

Attachment: fix copy-text button

The patch above inadvertently broke the "copy text" button. There is some funky code behind that button and having interspersed headers breaks it. This patch makes sure these rows still work, and print something.

Comment 19

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/efaa8959220e
https://hg.mozilla.org/mozilla-central/rev/8ed07c4d0e3e

Comment 20

[Francesco Lodolo [:flod]]

Commenting here since I see the leave-open flag, happy to file a new bug if needed.

A few strings changed in this landing without a new ID

-adapterDescription = Adapter Description
+adapterDescription = Description

-adapterDrivers = Adapter Drivers
+adapterDrivers = Drivers

-adapterRAM = Adapter RAM
+adapterRAM = RAM

The only way to ensure these changes are picked up by localization is to use different IDs.
https://developer.mozilla.org/en-US/docs/Mozilla/Localization/Localization_content_best_practices#Changing_existing_strings

Using adapterDescription2, adapterDrivers2, and adapterRAM2 would work.

Comment 21

[Gary [:streetwolf52]]

My Graphics card memory shows 4095 when it really is 8192MB.  Also, all the names of the various items are all called Features. This list was obtained in about:support Copy Text to Clipboard

Application Basics
------------------

Name: Firefox
Version: 48.0a1
Build ID: 20160415073426
Update Channel: default
User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:48.0) Gecko/20100101 Firefox/48.0
OS: Windows_NT 10.0 x86-64
Multiprocess Windows: 1/1 (Enabled by user)
Safe Mode: false


Graphics
--------

Features: Direct3D 11

Features: wheel input enabled; touch input enabled

Features: Google Inc. -- ANGLE (AMD Radeon (TM) R9 390 Series Direct3D11 vs_5_0 ps_5_0)

Features: Yes; Using D3D11 API

Features: true

Features: true (10.0.10586.0)


Features: Yes

Features: AMD Radeon (TM) R9 390 Series

Features: 0x1002

Features: 0x67b1

Features: 16.150.2211.1001

Features: 4-3-2016

Features: aticfx64 aticfx64 aticfx64 amdxc64 aticfx32 aticfx32 aticfx32 amdxc32 atiumd64 atidxx64 atidxx64 atiumdag atidxx32 atidxx32 atiumdva atiumd6a atitmm64

Features: 00000000

Features: 4095



Features: D [ Gamma: 2200 Pixel Structure: R ClearType Level: 100 Enhanced Contrast: 50 ] D [ Gamma: 2200 Pixel Structure: R ClearType Level: 100 Enhanced Contrast: 50 ]

Features: 0

Features: direct2d 1.1

Features: direct2d 1.1

Features: cairo

Features: D [ Gamma: 2200 Pixel Structure: R ClearType Level: 100 Enhanced Contrast: 50 ] D [ Gamma: 2200 Pixel Structure: R ClearType Level: 100 Enhanced Contrast: 50 ]

Comment 22

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/bdb163d0ba98

Comment 23

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/bdb163d0ba98

Comment 24

[Alexandru Simonca [:asimonca], Release Desktop QA]

Verified fixed FX 48.0a1 Win 10, Ubuntu 14.04 , OS X 10.11.1