Closed Bug 1263878 Opened 8 years ago Closed 8 years ago

Intermittent test_presentation_tcp_receiver_oop.html | The control channel is closed normally. - got 2152923159, expected +0

Categories

(Core :: DOM: Core & HTML, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla49
blocking-b2g 2.6+
Tracking Status
firefox47 --- fixed
firefox48 --- fixed
firefox49 --- fixed
b2g-v2.6 --- fixed

People

(Reporter: cbook, Assigned: CuveeHsu)

References

()

Details

(Keywords: intermittent-failure, Whiteboard: [ft:conndevices])

Attachments

(2 files, 2 obsolete files)

https://treeherder.mozilla.org/logviewer.html#?job_id=25601048&repo=mozilla-inbound 

10:04:26 INFO - 271 INFO TEST-UNEXPECTED-FAIL | dom/presentation/tests/mochitest/test_presentation_tcp_receiver_oop.html | The control channel is closed normally. - got 2152923159, expected +0
junior: you might want to take a look at this i guess :)
Flags: needinfo?(juhsu)
I'm not sure if it's a dup of Bug 1245560 or not.
(I rename the file in bug 1148307)
I keep the needinfo and will investigate it. Stay tuned.
Flags: needinfo?(juhsu)
This is pretty frequent. Please investigate or disable the test ASAP.
Flags: needinfo?(juhsu)
Flags: needinfo?(juhsu)
Sorry for wrongly cleaning the needinfo twice.

I found a weird fact that |NotifyReceiverReady| is before|HandleSessionRequest|. I'm still working on it.
Attached patch fix-promise-timing.patch (obsolete) — Splinter Review
should be the same as bug 1261595, let's try my patch first.
Attachment #8744763 - Flags: review?(juhsu)
Attached patch randomized session id (obsolete) — Splinter Review
Here's the patch for randomized session ID.

Do you think if we still need to extend the time-out?
Assignee: nobody → juhsu
Attachment #8744769 - Flags: review?(schien)
Attachment #8744763 - Attachment is obsolete: true
Attachment #8744763 - Flags: review?(juhsu)
Comment on attachment 8744769 [details] [diff] [review]
randomized session id

Review of attachment 8744769 [details] [diff] [review]:
-----------------------------------------------------------------

let's try this patch first.
Attachment #8744769 - Flags: review?(schien) → review+
a minor change. carry r+
Let's wait for the treeherder green
Attachment #8744769 - Attachment is obsolete: true
Attachment #8744787 - Flags: review+
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/97a52fc1216a
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla48
Target Milestone: mozilla48 → mozilla49
NOTE: Please see https://wiki.mozilla.org/Release_Management/B2G_Landing to better understand the B2G approval process and landings.

[Approval Request Comment]
Bug caused by (feature/regressing bug #): Bug 1263878
User impact if declined: Every patches for Presentation API need two versions of them, one for m-c and another one for b2g.
Testing completed: manual testing passed
Risk to taking this patch (and alternatives if risky): no risk since this patch only has impacts on tests
String or UUID changes made by this patch:
Attachment #8758528 - Flags: approval-mozilla-b2g48?
Whiteboard: [ft:conndevices]
blocking-b2g: --- → 2.6+
Comment on attachment 8758528 [details] [review]
randomized session id (v2.6)

Approve for TV 2.6
Attachment #8758528 - Flags: approval-mozilla-b2g48? → approval-mozilla-b2g48+
You need to log in before you can comment on or make changes to this bug.