Closed Bug 1263941 Opened 4 years ago Closed 4 years ago

History is not displayed in the 3-dot menu if History panel is set as default after it was hidden

Categories

(Firefox for Android :: General, defect)

ARM
Android
defect
Not set

Tracking

()

VERIFIED FIXED
Firefox 48
Tracking Status
firefox45 --- unaffected
firefox46 --- affected
firefox47 --- verified
firefox48 --- verified
fennec 47+ ---

People

(Reporter: sflorean, Assigned: liuche)

References

Details

Attachments

(2 files)

Attached image screenshot.png
Environment: 
Device: Asus Transformer Pad (Android 4.2.1);
Build: Nightly 48.0a1 (2016-04-11);

Steps to reproduce:
1. Go to Settings->General->Home; 
2. Hide History panel; 
3. Go back to about:home and tap the 3-dot menu button;
4. Observe that Bookmarks and History are not displayed;
5. Go to Settings->General->Home;
6. Tap on History->Set as default;
7. Repeat step 3.
 

Expected result:
History is displayed in the 3-dot menu.

Actual result:
History is not displayed in the 3-dot menu.

Notes:
Please check the attached screenshot.
Also reproducible with Bookmarks panel.
tracking-fennec: --- → ?
I didn't add a listener into setDefault, so that's all that we need to do for this. I'll take care of this!
Assignee: nobody → liuche
Blocks: home-panels
No longer blocks: combined-history
Comment on attachment 8743410 [details]
MozReview Request: Bug 1263941 - History is not displayed in the 3-dot menu if History panel is set as default after it was hidden. r=sebastian

https://reviewboard.mozilla.org/r/47743/#review44791
Attachment #8743410 - Flags: review?(s.kaspari) → review+
No longer blocks: home-panels
I don't think this blocks us shipping the menu items in 46, but we should uplift to 47.
tracking-fennec: ? → 47+
https://hg.mozilla.org/mozilla-central/rev/2570cd8ec0bd
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 48
Verified as fixed in build 48.0a2 2016-04-26;
Device: Asus Transformer Pad (Android 4.2.1).
Sigh, this never got uplifted... can we uplift this for 47?
Flags: needinfo?(liuche)
Comment on attachment 8743410 [details]
MozReview Request: Bug 1263941 - History is not displayed in the 3-dot menu if History panel is set as default after it was hidden. r=sebastian

Approval Request Comment
[Feature/regressing bug #]: Bug in original patches in bug 1255077 and bug 1231792
[User impact if declined]: History/Bookmark panel set as default from hidden won't show up in the 3-dot menu
[Describe test coverage new/current, TreeHerder]: Nightly, Aurora
[Risks and why]: low, adding one extra case for triggering 3-dot menu visibility
[String/UUID change made/needed]: none
Flags: needinfo?(liuche)
Attachment #8743410 - Flags: approval-mozilla-beta?
Verified based on comment 7.
Status: RESOLVED → VERIFIED
Comment on attachment 8743410 [details]
MozReview Request: Bug 1263941 - History is not displayed in the 3-dot menu if History panel is set as default after it was hidden. r=sebastian

Fix was verified on 48, Beta47+
Attachment #8743410 - Flags: approval-mozilla-beta? → approval-mozilla-beta+
Verified as fixed on Firefox 47 Beta 4 on Samsung Galaxy S6 Edge (Android 5.1.1)
You need to log in before you can comment on or make changes to this bug.