Provide a tooltip on Synced Tabs like in the History menu panel

VERIFIED FIXED in Firefox 48

Status

()

defect
VERIFIED FIXED
3 years ago
3 years ago

People

(Reporter: rfeeley, Assigned: eoger)

Tracking

unspecified
Firefox 48
Points:
---
Bug Flags:
firefox-backlog +

Firefox Tracking Flags

(firefox48 verified)

Details

Attachments

(2 attachments, 1 obsolete attachment)

(Reporter)

Description

3 years ago
Items in the History menu panel possess a tooltip with the full page title, a line break, and the full URL in a tooltip. We should offer this in the Synced Tabs menu panel as well.
Flags: firefox-backlog+
(Assignee)

Comment 1

3 years ago
Posted patch bug-1263943.patch (obsolete) — Splinter Review
Assignee: nobody → edouard.oger
Status: NEW → ASSIGNED
Attachment #8741180 - Flags: review?(markh)
Comment on attachment 8741180 [details] [diff] [review]
bug-1263943.patch

Review of attachment 8741180 [details] [diff] [review]:
-----------------------------------------------------------------

::: browser/components/customizableui/CustomizableWidgets.jsm
@@ +474,5 @@
>      },
>      _createTabElement(doc, tabInfo) {
>        let win = doc.defaultView;
>        let item = doc.createElementNS(kNSXUL, "toolbarbutton");
> +      let tooltipText = (tabInfo.title != "" ? tabInfo.title + "\n" : "") + tabInfo.url;

I think the conditional reading just |tabInfo.title| is better (ie, drop the |!= ""|)
Attachment #8741180 - Flags: review?(markh) → review+
(Assignee)

Comment 3

3 years ago
Carrying r+ forward
Attachment #8741180 - Attachment is obsolete: true
Attachment #8741417 - Flags: review+
(Assignee)

Updated

3 years ago
Keywords: checkin-needed

Comment 5

3 years ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/d0b6d063cf49
Status: ASSIGNED → RESOLVED
Last Resolved: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 48
I have reproduced this bug with Firefox Nightly 48.0a1 (Build ID: 20160412050029) on 
Windows 8.1, 64-bit.

Verified as fixed with Firefox Developer edition 48.0a2 (Build ID:20160527004031)
Mozilla/5.0 (Windows NT 6.3; WOW64; rv:48.0) Gecko/20100101 Firefox/48.0
QA Whiteboard: [bugday-20160525]
I have reproduced this bug on Nightly 48.0a1 (2016-04-12) on Ubuntu 16.04 LTS, 64 bit!

The bug's fix is now verified on Latest Aurora 48.0a2!

Build ID: 20160603004101
User Agent: Mozilla/5.0 (X11; Linux x86_64; rv:48.0) Gecko/20100101 Firefox/48.0

As this bug fix is verified on Windows 8.1, 64-bit(comment 6), I am marking this as verified!
Status: RESOLVED → VERIFIED
QA Whiteboard: [bugday-20160525] → [bugday-20160525][testday-20160603]
You need to log in before you can comment on or make changes to this bug.