1263943 - Provide a tooltip on Synced Tabs like in the History menu panel

Status: VERIFIED FIXED

(Firefox :: Sync, defect)

Description

[Ryan Feeley [:rfeeley]]

Attachment: synced-tabs-tooltips.png

Items in the History menu panel possess a tooltip with the full page title, a line break, and the full URL in a tooltip. We should offer this in the Synced Tabs menu panel as well.

Comment 1

[Edouard Oger [:eoger]]

Attachment: bug-1263943.patch

Comment 2

[Mark Hammond [:markh] [:mhammond]]

Comment on attachment 8741180 [details] [diff] [review]
bug-1263943.patch

Review of attachment 8741180 [details] [diff] [review]:
-----------------------------------------------------------------

::: browser/components/customizableui/CustomizableWidgets.jsm
@@ +474,5 @@
>      },
>      _createTabElement(doc, tabInfo) {
>        let win = doc.defaultView;
>        let item = doc.createElementNS(kNSXUL, "toolbarbutton");
> +      let tooltipText = (tabInfo.title != "" ? tabInfo.title + "\n" : "") + tabInfo.url;

I think the conditional reading just |tabInfo.title| is better (ie, drop the |!= ""|)

Comment 3

[Edouard Oger [:eoger]]

Attachment: bug-1263943.patch

Carrying r+ forward

Comment 4

[Pulsebot]

https://hg.mozilla.org/integration/fx-team/rev/d0b6d063cf49

Comment 5

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/d0b6d063cf49

Comment 6

[Mohammad Maruf Islam]

I have reproduced this bug with Firefox Nightly 48.0a1 (Build ID: 20160412050029) on 
Windows 8.1, 64-bit.

Verified as fixed with Firefox Developer edition 48.0a2 (Build ID:20160527004031)
Mozilla/5.0 (Windows NT 6.3; WOW64; rv:48.0) Gecko/20100101 Firefox/48.0

Comment 7

[Khalid Syfullah Zaman [:khalid32]]

I have reproduced this bug on Nightly 48.0a1 (2016-04-12) on Ubuntu 16.04 LTS, 64 bit!

The bug's fix is now verified on Latest Aurora 48.0a2!

Build ID: 20160603004101
User Agent: Mozilla/5.0 (X11; Linux x86_64; rv:48.0) Gecko/20100101 Firefox/48.0

As this bug fix is verified on Windows 8.1, 64-bit(comment 6), I am marking this as verified!