Closed Bug 1263958 Opened 8 years ago Closed 8 years ago

AUS does not advertise Widevine CDM

Categories

(Release Engineering :: General, defect)

Product:
Release Engineering
Component:
General
Type:
defect
Priority:
Not set
Severity:
major

Tracking

(Not tracked)

Status:
VERIFIED FIXED

People

(Reporter: hsivonen, Assigned: nthomas)

References

Details

Steps to reproduce:
 1) Download Nightly for Windows or Mac.
 2) Run it.
 3) Open the plug-ins pane in the Add-on manager.
 4) Wait.
 5) Close it.
 6) Open it again.
 7) Wait.
 8) Quit Firefox.
 9) Run it.
10) Open the plug-ins pane in the Add-on manager.

Actual results:
Add-on Manager keeps saying that the Widevine CDM will be downloaded shortly. The CDM doesn't appear in the profile folder.

Expected results:
Expected the CDM to be downloaded and installed.
Assignee: nobody → ksteuber
cpearce, can you get the https://clients2.googleusercontent.com/... URLs and hashes to releng, please?
Assignee: ksteuber → nobody
Component: General → Other
Flags: needinfo?(cpearce)
Product: Firefox → Release Engineering
QA Contact: mshal
Summary: Widevine CDM not downloading → AUS does not advertise Widevine CDM
Fwiw I chatted with cpearce yesterday briefly and said we'd get a request to add it our update server "soon".

I guess this bug will be it, we'll likely also need to setup a new whitelisted url in Balrog to support this, along with a code deploy before it will work.
(In reply to Justin Wood (:Callek) [back on Mar 21] from comment #3)
> Fwiw I chatted with cpearce yesterday briefly and said we'd get a request to
> add it our update server "soon".
> 
> I guess this bug will be it, we'll likely also need to setup a new
> whitelisted url in Balrog to support this, along with a code deploy before
> it will work.

Whitelists are maintained in the ini at the moment, no need to wait for a code deploy. I can update the ini when we have the domain.
The addons we need to publish are:

MacOSX 10.7 and later, Firefox 48 and later:

<addon id="gmp-widevinecdm" url="https://clients2.googleusercontent.com/crx/blobs/QwAAAHF3InbmK-wFIemaY3I3BCOjtV4w8QUJBmXnOVyLFWoqPTp3w_QSaJdATM-vmoKWOzDU-zeHxF-6zkhQXWA23ymc4MSzzyiSiSvGeuLpxh6AAMZSmuUt3YZ2reKlMk-CRy88NwzPtEaCgw/" hashFunction="sha512" hashValue="35b7586dd5cdb9373abc42c5c3424ecc953596489d88040f20bef35f475f018e643743f091354643eb8687fa520dec508e55c55b2403d402ed5092b3ddbe8e47" size="2163186" version="1.4.8.885"/>

Windows Vista and later, Win32 Firefox 48 and later:

<addon id="gmp-widevinecdm" url="https://clients2.googleusercontent.com/crx/blobs/QwAAAHF3InbmK-wFIemaY3I3BCOEblQvxf5_rLSB9BNCJwLacEyZM-IGsNowEZTeU5qG7G63QGFcdNpnDs--euoRMzysYZwOh02jxtQ6PgpCPBhIAMZSmuWUsI0GFzG6jr6PrhJi0gblaUwtmA/" hashFunction="sha512" hashValue="5f7a7f8010219310c469861649e2f8cb99de6c6732c0ac24f533c79fe2542d07584f872f9fd4221976f17b109afd1afcc1314788a9f0e181d3df240d4192fd0f" size="2865019" version="1.4.8.885"/>

Windows 7 and later, Win64 Firefox 48 and later:

<addon id="gmp-widevinecdm" url="https://clients2.googleusercontent.com/crx/blobs/QwAAAHF3InbmK-wFIemaY3I3BCOlBIvoDMAma8GvG4TlJV63V3z4MNfCj1MF1whPFD2tYicAsQ5601cDfdLGi-qBszggckqtw3PypWXaWYDlcTCuAMZSmuUSY2gaLLS7cCjU4BFP6MCiAk2lGA/" hashFunction="sha512" hashValue="90aa055d82f87c9cd4080795126e9fe85b772e2ac22560edb3ad70b645f22386020ef401ac612c4d2c39de0b054898eb5a180aef9aedb89d559ba8713ae45a2a" size="2852924" version="1.4.8.885"/>


Hopefully we're going to uplift to Firefox 47, I'll create a new bug once that's underway.

Note: the Widevine downloader won't be working until bug 1264173 is fixed, but we'd like to get the balrog rule change rolling, as we want to start testing Amazon Prime Video ASAP.
Flags: needinfo?(cpearce)
Flags: needinfo?(bugspam.Callek)
Flags: needinfo?(bhearsum)
(In reply to Chris Pearce (:cpearce) from comment #5)
> The addons we need to publish are:
> 
> MacOSX 10.7 and later, Firefox 48 and later:

Lets make that MacOSX 10.6 and later, Firefox 48 and later.
Per IRC, I was asked to make sure I treat this bug with urgency...

In chatting with :kentuckyfriedtakahe, we confirmed me starting that work tomorrow morning, with an expectation of "ready in AUS no later than 9am PT" is acceptable.

The "downloader not ready" (as per c#5 and Bug 1264173) is expected to land today, so will likely be in tomorrow's nightly.

I'll update this bug as I have more to share.
I think I have this set up on the nightlytest channel, with rules 335-338 (see https://aus4-admin.mozilla.org/rules#GMP if you have access). There are two more rules than recent form, because we need to explicitly block Vista on Win64 (so it doesn't fall through to the win32 rule), and handle mac. Also updated and cleaned up https://wiki.mozilla.org/User:Bhearsum/GMP_Updates to try to keep track of our tangled web.

cpearce, please test on nightlytest. If that goes OK we can change the channel restriction to nightly, or remove it altogether and rely on the version >= 48.0a1 limit.
Flags: needinfo?(bugspam.Callek)
Flags: needinfo?(bhearsum)
Flags: needinfo?(cpearce)
Nightlytest is working as expected. Please push this out to version >= 48.0a1. FYI, we'll need to change that to 47 in about a week.
Flags: needinfo?(cpearce)
I've removed the nightlytest channel restriction, so now >=48.0.1 and the assorted build target/OS version limits to make it work. This will make it easier to drop the limit to 47.0a1 later, as we'll be on two channels then.
Per IRC I've limited mac to 64bit (buildTarger==Darwin_x86_64-gcc3-u-i386-x86_64), since the crx has only this in it:
_platform_specific/mac_x64/libwidevinecdm.dylib: Mach-O 64-bit dynamically linked shared library x86_64

FWIW, this leaves out anyone who is stripping their universal binary back to 64bit only, but meh.
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Assignee: nobody → nthomas
We pushed the URLs to version 1.4.8.885, but that doesn't work, so we should push the version we tested more thoroughly, version 1.4.8.866:

Win32 CDM CRX:
https://clients2.googleusercontent.com/crx/blobs/QwAAAHF3InbmK-wFIemaY3I3BCOrQhs58MSM0PACaKZwziDKslDhLuYcy_uiEOziZrKSpdyKC2u0xWpTd8_mlQlb2TOoodI6B6uEyCjEHUIiCrE_AMZSmuUICZ9D46JdFolcNTWzSkVgupRLMQ/
Sha512: 7a8f3066fb002d80d487322804cda488faa790c0246fdc20bf549b8bbb5dcebca7dd98a569482bf3c66bd8085b28b8e99b5d8f7d5423665e766bd9c4ed475c61
Size: 3984450
Version: 1.4.8.866

Win64 CDM CRX:
https://clients2.googleusercontent.com/crx/blobs/QwAAAHF3InbmK-wFIemaY3I3BCNvR2rrX0K23b0p5zZ1qOLkmIGJvKmgmRfkCKAUDhVGGsjhvvC0i6KY-t7IphgJnrRaZR1a15eJ6xRF6F9qjEOHAMZSmuXskSZVj783rPph4Nibpn-frK1g9w/
Sha512: 27f985d2f9dd7acd213d3650c2f684840d7f542af43bfe2c1185f526e7b89c21e1d0b481d12dcb45d00fb2e9897847f8b51d1e3e71f8896a0ffa84e073ac4de1
Size: 4022211
Version: 1.4.8.866

MacOSX 64:
https://clients2.googleusercontent.com/crx/blobs/QwAAAHF3InbmK-wFIemaY3I3BCNBg8r65TbaAwbDoXvQTFHyscauwpRzTgDtckVDJL7xSI-QPPsi4Ga_v-9gFX5Oa9AGlvYCddTDRpbQHextOpBiAMZSmuUQozcB8RrPw-te0h0bgcJTNuHu9g/
Sha512: 21a85b88a5ca007faf44bbe9f854b9d02a980cedd07bfd586445cb32a749cb2704c9235ec7c1f942925989ee23ac23a6983c67195af1af551f360749b98e02b3
Size: 2189136
Version: 1.4.8.866
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Created a new release GMP-20160415-Widevine-v1.4.8.866-CDM-v17-OpenH264-v1.5.3 and pointed rules 335, 336, and 337 at it.
Status: REOPENED → RESOLVED
Closed: 8 years ago → 8 years ago
Resolution: --- → FIXED
Rule 337 should be no CDM (OSX)
Flags: needinfo?(nthomas)
Oh, you noticed I cheated there, curses. Was really trying to avoid more than one release, but apparently that's in our future anyway.

Updated 337 to point at GMP-20160415-Widevine-v1.4.8.866-No-CDM-OpenH264-v1.5.3.
Flags: needinfo?(nthomas)
Another issue I've encountered: for MacOSX builds I do locally, I'm not getting the Widevine CDM downloaded (but I am getting the OpenH264 GMP downloaded). Nightly MacOSX builds are working fine.

For example, for Nightly, we're requesting the update.xml file from:

https://aus5.mozilla.org/update/3/GMP/48.0a1/20160417030601/Darwin_x86_64-gcc3-u-i386-x86_64/en-US/nightly/Darwin%2015.4.0/default/default/update.xml

And that contains gmp-widevinecdm, but my local builds are requesting update.xml from:

https://aus5.mozilla.org/update/3/GMP/48.0a1/20160418110806/Darwin_x86_64-gcc3/en-US/default/Darwin%2015.4.0/default/default/update.xml

And that only contains the openh264 entry.

Can we get MacOSX local builds also able to download the Widevine CDM please?
Flags: needinfo?(nthomas)
Fixed by dropping the buildTarget==Darwin_x86_64-gcc3-u-i386-x86_64 restriction and detecting mac by only looking for 'Darwin' in %OS_VERSION% (just after the channel).
Flags: needinfo?(nthomas)
Thanks, that works. :)
Callek: Can you please modify the rules to affect Firefox >= 47 instead of >= 48? No need to test on NightlyTest, just change the version numbers in the production rules.

(nthomas will have a public holiday on Monday, and it's the weekend in his locale, so I'm asking you...)
Flags: needinfo?(bugspam.Callek)
Done, I'm updating https://wiki.mozilla.org/User:Bhearsum/GMP_Updates now
Flags: needinfo?(bugspam.Callek)
I've tested on MacOSX, and that's working. 

Thanks for jumping on this so quickly.
I have tested this issue on:
- Win 7 x32 and x64, 8 x64, 8.1 x32, 10 x64
- Mac OS 10.11 and 10.9 

With the latest Nightly(49.0a1, Build ID: 20160426044609), latest Aurora(48.0a2, Build ID: 20160427004105) and 
latest Beta (47.0b1, Build ID: 20160425205003).
I can confirm that this issue is no longer reproducible.
Based on Comment 23 setting status to Verified Fixed.
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.