126396 - nvhn.nl : menu structure only displayed after mouse over and no sub menus

Status: RESOLVED FIXED

(Tech Evangelism Graveyard :: Dutch, defect, P2)

Description

[Rein Smedinga]

From Bugzilla Helper:
User-Agent: Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:0.9.8) Gecko/20020204
BuildID:    2002020406

The above mentioned web site cannot be viewed with Mozilla completely. Two errors:
1. the menu structure at the left is displayed only after a mouse over
2. no submenus appear when the mouse in on top of an item

Reproducible: Always


Do they use non-standard javascripts??

Comment 1

[Phil Schwartau]

Confirming with Mozilla trunk build 2002021413 WinNT. On initial load,
there is mostly white space between the blue headers "actueel" and "weer"
on the upper-left side of the page. I did see one menu entry between them, 
however: "jongeren" just above the "weer" header.

I see these errors in Tasks > Tools > JavaScript Console:

       Error: Clock is not defined
       Source File: http://213.136.5.38/dvhnblok.asp
       Line: 46

       Error: document.body.insertAdjacentHTML is not a function
       Source File: http://www.nvhn.nl/Javascript/groepen.js
       Line: 513


The other menu items only appear after you mouse over where they 
should be. Also confirmed on my Linux build. OS: Win2K ---> All.

It's also true that we get no submenus. I'm getting this error
in the JavaScript Console:

       Error: window.event has no properties
       Source File: http://www.nvhn.nl/Javascript/groepen.js
       Line: 265

That's a bad sign; window.event is non-standard, IE-only syntax.
I will look into this further -

Comment 2

[Phil Schwartau]

Here is the first error, from http://213.136.5.38/dvhnblok.asp

<style type="text/css">
      etc.
#Clock {position:relative;left:0px;}
      etc.
</style>


<div id=Clock align=center>

<script type=text/javascript>

function tick(teller){
  nullen=""
  for (i=1;i<=(AantalDigits-String(teller).length);i++){
  	nullen = nullen + "0"
  }

  Clock.innerHTML = "<span class=grijs>" + nullen + "</span>" + teller ;
  window.setTimeout("tick(" + (teller-1) + ");", 1000);
}
</script>


In W3C-standard DOM you cannot refer this way to a <div> with id="Clock".
You have to use document.getElementById("Clock").

Comment 3

[Phil Schwartau]

The second error is at this line in http://www.nvhn.nl/Javascript/groepen.js :

       document.body.insertAdjacentHTML("beforeEnd", str);

This is IE-only syntax. See "Standards Information" at the bottom of

   http://msdn.microsoft.com/workshop/author/dhtml/reference/methods/
   insertadjacenthtml.asp


The error on mouseovers is at this line:

function GetMousePosition(e) {
  // Save mouse pointer position.

  if (is_nav4) {
    mouseX = e.pageX;
    mouseY = e.pageY;
  }
  else {
    if (is_ie4up) {
      mouseX = window.event.clientX + document.body.scrollLeft;
      mouseY = window.event.clientY + document.body.scrollTop;
    }
    else {
	  if (document.body != null) 
	  {
        mouseX = window.event.clientX + document.body.scrollLeft; <<<---Line 265
        mouseY = window.event.clientY + document.body.scrollTop;
      }
    }
  }
}

As stated above, window.event is another IE-only syntax.
Reassigning this bug to Tech Evangelism -

Comment 4

[Frederic Bezies]

Confirming it with build 2002050108 - WinXP.

Comment 5

[Mathieu Pillard [:mat]]

ok for the top frame, the fix is easy :
in http://www.nvhn.nl/Topframe/0,5482,26-1-0,00.html, replace the script part
around line 115 with this one :

function ShowIconText(arg){
if (document.all) {
	eval('document.all["' + arg + '"].style.visibility = "visible"')
}
else if (document.getElementById)
	document.getElementById(arg).style.visibility = "visible";
}
function HideIconText(arg) {
if (document.all) {
eval('document.all["' + arg + '"].style.visibility = "hidden"') }
else if (document.getElementById)
	document.getElementById(arg).style.visibility = "hidden";
}


I will upload fixes for the others parts of the site.

Comment 6

[Frederic Bezies]

Contact : [e-mail]

Comment 7

[Rein Smedinga]

The website has a new address: www.dvhn.nl instead of www.nvhn.nl.

The wether pages are still wrong, see in the right column under "weer" 
No maps are shown in the window that pops up and so no change of info when going
over that map.

Comment 8

[Mathieu Pillard [:mat]]

are the bugs on the new page the same than the one the original reporter pointed
out ? if not, wed better close that bug and file a new one

Comment 9

[Rein Smedinga]

The bug is still there. 
(Only the name of the corresponding newspaper has changed and so has its url.)

Comment 10

[Patrick]

Rein : site seems to behave the same for Moz and IE for me now?

You know the story by now ;) If i get no reports that this site is still
misbehaving I will assume that the problem has been resolved and mark this bug
as such.

Comment 11

[Rein Smedinga]

Website seems te behave nicely under Mozilla now. So: wfm.

The wetherpages are still wrong, I will create a new bug for that.

Comment 12

[Patrick]

new site : wfm

Comment 13

[Brant Gurganus]

v

Comment 14

[Bob Clary [:bc] (inactive)]

tech evang june 2003 reorg

Comment 15

[[github robot]]

Commits pushed to master at https://github.com/mozilla/bedrock

https://github.com/mozilla/bedrock/commit/1944f5377679229ac5fe771bee5e91ec6a1c6b80
[fix bug 126396] Redesigned Mozilla newsletter form

Only on home, /about, and /about/legal right now.

https://github.com/mozilla/bedrock/commit/ef8faad7ddaac2df392a0e455a684f0efff6d8cf
Merge pull request #4117 from craigcook/bug-1269396-mozilla-newsletter-form

[fix bug 126396] Redesigned Mozilla newsletter form