Closed Bug 1263962 Opened 4 years ago Closed 4 years ago

Expand on the StyleAnimationValue::ExtractComputedValue comment

Categories

(Core :: Layout, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla48
Tracking Status
firefox48 --- fixed

People

(Reporter: jwatt, Assigned: jwatt)

Details

Attachments

(1 file)

No description provided.
Attached patch patchSplinter Review
Attachment #8740464 - Flags: review?(dholbert)
Comment on attachment 8740464 [details] [diff] [review]
patch

Review of attachment 8740464 [details] [diff] [review]:
-----------------------------------------------------------------

Maybe s/comment/documentation/ in the commit message? not a big deal.

Anyway, r=me, with the following typo fixed:

::: layout/style/StyleAnimationValue.h
@@ +225,5 @@
>    /**
>     * Gets the computed value for the given property from the given style
>     * context.
>     *
> +   * Obtaining the computed value allows us to animated properties when the

nit: "to animate" (not "to animated")
Attachment #8740464 - Flags: review?(dholbert) → review+
https://hg.mozilla.org/mozilla-central/rev/29ec4af8204b
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla48
You need to log in before you can comment on or make changes to this bug.