Closed Bug 1263982 Opened 8 years ago Closed 8 years ago

[e10s] It require extra one wheel tick in order to scroll the page

Categories

(Core :: Widget, defect, P1)

48 Branch
Unspecified
All
defect

Tracking

()

RESOLVED FIXED
mozilla48
Tracking Status
e10s + ---
firefox47 --- unaffected
firefox48 --- fixed

People

(Reporter: alice0775, Assigned: enndeakin)

References

Details

(Keywords: regression, ux-consistency)

Attachments

(3 files)

After landing Bug 982121, It require extra wheel tick in order to scroll the page if select pull down is open.

Steps To Reproduce:
1. Open web page with <select>
   e.g. https://bugzilla.mozilla.org/userprefs.cgi?tab=settings

2. Open a select pull down
3. Attempt to scroll page
   i.e., Turn mouse wheel

Actual Results:
It needs 2 tick to start scroll
( 1st tick: hide pulldown
  2nd tick: scroll)

Expected Results:
1 tick to start scroll
( 1st tick: hide pulldown and scroll at the same time)
Summary: It require extra one wheel tick in order to scroll the page → [e10s] It require extra one wheel tick in order to scroll the page
We could just remove rolluponmousewheel="true" from the ContentSelectDropdown popup. This makes it not match non-e10s (we could change that too) but matches IE and Windows behaviour.
By the way, I do not like IE/Edge/Chrome behavior, that's why I use Firefox.
tracking-e10s: --- → +
Priority: -- → P1
Assignee: nobody → enndeakin
Component: Layout → Widget
This prevents the mousewheel from hiding the popup on e10s.
This patch does the same with non-e10s select popups.
The alternative is to allow the mousewheel to rollup the popups but change nsXULPopupManager::ShouldConsumeOnMouseWheelEvent to return false for the select popup.
We should also fix the consume event flag to be consistent with other platforms. They ignore any existing value and have the result Rollup replace it.

This fixes the issue without changing the rollup behaviour.

Part 1 and 2 are an additional fix to match platform convention, but we could fix those in bug 1265308. We should use this patch for cross-platform consistency.
Attachment #8743875 - Flags: review?(jmathies)
Attachment #8743875 - Flags: review?(jmathies) → review+
https://hg.mozilla.org/integration/mozilla-inbound/rev/2747cac2de2fcfd3233930a10e4fa560b3376b60
Bug 1263982, the return value of Rollup should override the consume value as with other platforms, r=jmathies
https://hg.mozilla.org/mozilla-central/rev/2747cac2de2f
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla48
QA Whiteboard: [good first verify]
You need to log in before you can comment on or make changes to this bug.