Closed Bug 1263983 Opened 5 years ago Closed 1 month ago

Investigate defaultSearch `null` values in core ping

Categories

(Firefox for Android Graveyard :: General, defect)

All
Android
defect
Not set
normal

Tracking

(Not tracked)

RESOLVED INCOMPLETE

People

(Reporter: mcomella, Unassigned)

References

Details

Continuation of bug 1249288. We expect nulls for some set of conditions (see [1]) but it's not clear if we're getting more than we should expect (~1%). The search engine retrieval code is a bit complex, which is why we haven't looked into this sooner.

See https://bugzilla.mozilla.org/show_bug.cgi?id=1249288#c65 and subsequent comments.

[1]: https://gecko.readthedocs.org/en/latest/toolkit/components/telemetry/telemetry/core-ping.html#defaultsearch
fwiw, if the numbers are insignificant, for now I think it's better for me to prioritize finishing the telemetry work rather than nailing this down.

Also, Sebastian or Margaret might have better context on this code and when the search engines are null so it could be more efficient for them to look into the issue.
We're going to validate this against release and if the numbers don't look too bad, we'll close this.

fwiw, the code to retrieve the search engine is very difficult to follow – it grabs the engine asynchronously, sometimes getting it from over the air, making it hard to figure out where the null might be coming from which is why I'm inclined to sweep it under the rug if the numbers are insignificant. (Practically, I assume it's null when the over-the-air search engine has come in in time, but the docs say we can return null in many places so...)

NI Georg since we're waiting on release data validation.
Flags: needinfo?(gfritzsche)
Blocks: 1251614
No longer blocks: core-ping
Flags: needinfo?(gfritzsche)
We have completed our launch of our new Firefox on Android. The development of the new versions use GitHub for issue tracking. If the bug report still reproduces in a current version of [Firefox on Android nightly](https://play.google.com/store/apps/details?id=org.mozilla.fenix) an issue can be reported at the [Fenix GitHub project](https://github.com/mozilla-mobile/fenix/). If you want to discuss your report please use [Mozilla's chat](https://wiki.mozilla.org/Matrix#Connect_to_Matrix) server https://chat.mozilla.org and join the [#fenix](https://chat.mozilla.org/#/room/#fenix:mozilla.org) channel.
Status: NEW → RESOLVED
Closed: 1 month ago
Resolution: --- → INCOMPLETE
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in before you can comment on or make changes to this bug.