1264095 - test_page_errors.html is going to permafail when Gecko 48 merges to Aurora

Status: RESOLVED FIXED

(DevTools :: Console, defect)

Description

[Ryan VanderMeulen [:RyanVM]]

[Tracking Requested - why for this release]: Test permafail when Gecko 48 merges to Aurora.

https://treeherder.mozilla.org/logviewer.html#?job_id=19229413&repo=try

TEST-UNEXPECTED-FAIL | devtools/shared/webconsole/test/test_page_errors.html | errorMessage: /repeat count.*less than infinity/ matched SyntaxError: expected expression, got '*'
TEST-UNEXPECTED-FAIL | devtools/shared/webconsole/test/test_page_errors.html | property 'errorMessageName' - got "JSMSG_UNEXPECTED_TOKEN", expected "JSMSG_RESULTING_STRING_TOO_LARGE"

Comment 1

[Morgan Phillips [:mrrrgn]]

(In reply to Ryan VanderMeulen [:RyanVM] from comment #0)
> [Tracking Requested - why for this release]: Test permafail when Gecko 48
> merges to Aurora.
> 
> https://treeherder.mozilla.org/logviewer.html#?job_id=19229413&repo=try
> 
> TEST-UNEXPECTED-FAIL | devtools/shared/webconsole/test/test_page_errors.html
> | errorMessage: /repeat count.*less than infinity/ matched SyntaxError:
> expected expression, got '*'
> TEST-UNEXPECTED-FAIL | devtools/shared/webconsole/test/test_page_errors.html
> | property 'errorMessageName' - got "JSMSG_UNEXPECTED_TOKEN", expected
> "JSMSG_RESULTING_STRING_TOO_LARGE"

Something has caused the error I'd intended to trigger to change. This isn't a critical bug IMO, the test just needs to be updated. Investigating.

Comment 2

[Morgan Phillips [:mrrrgn]]

Sorry, this is "critical."

Comment 3

[Morgan Phillips [:mrrrgn]]

Attachment: starstart-to-e.diff

Verified working on Aurora locally.

Comment 4

[Morgan Phillips [:mrrrgn]]

So, this begs the question, why does say |2**2| now raise a syntax error. I'll ask tomorrow in JSAPI.

Comment 5

[Morgan Phillips [:mrrrgn]]

So, this begs the question, why does say |2**2| now raise a syntax error? I'll ask tomorrow in JSAPI.

Comment 6

[Brian Grinstead [:bgrins]]

(In reply to Morgan Phillips [:mrrrgn] from comment #5)
> So, this begs the question, why does say |2**2| now raise a syntax error?
> I'll ask tomorrow in JSAPI.

I've seen failures like this before caused where language features are enabled only in Nightly builds

Comment 7

[Ryan VanderMeulen [:RyanVM]]

Terrence had a similar issue with ** in bug 1261649.

Comment 8

[Ryan VanderMeulen [:RyanVM]]

Comment on attachment 8740870 [details] [diff] [review]
starstart-to-e.diff

Review of attachment 8740870 [details] [diff] [review]:
-----------------------------------------------------------------

Not sure I'm a legit reviewer here, but LGTM anyway :P

Comment 9

[Morgan Phillips [:mrrrgn]]

(In reply to Ryan VanderMeulen [:RyanVM] from comment #8)
> Comment on attachment 8740870 [details] [diff] [review]
> starstart-to-e.diff
> 
> Review of attachment 8740870 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> Not sure I'm a legit reviewer here, but LGTM anyway :P

What's the next step on this ? Request uplift or just merge to inbound ?

Comment 10

[Ryan VanderMeulen [:RyanVM]]

Just needs to land on inbound. 48 doesn't go to Aurora until the 25th.

Comment 11

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/c3f94b249ad6

Comment 12

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/c3f94b249ad6