Closed
Bug 1264129
Opened 9 years ago
Closed 9 years ago
Misc pyconfigure cleanups
Categories
(Firefox Build System :: General, defect)
Firefox Build System
General
Tracking
(firefox48 fixed)
RESOLVED
FIXED
mozilla48
Tracking | Status | |
---|---|---|
firefox48 | --- | fixed |
People
(Reporter: glandium, Assigned: glandium)
References
Details
Attachments
(2 files)
No description provided.
Assignee | ||
Comment 1•9 years ago
|
||
Also get an absolute path for the shell.
Review commit: https://reviewboard.mozilla.org/r/45903/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/45903/
Attachment #8740684 -
Flags: review?(gps)
Attachment #8740685 -
Flags: review?(gps)
Assignee | ||
Comment 2•9 years ago
|
||
The configure.in is a small wrapper around python configure, that is
still a m4 script so that people running autoconf manually can still
do so without breaking their stuff (and we have jobs that do that
on automation as well).
But considering how simple the m4 is, to avoid having the autoconf
checking code twice (once in client.mk and once in
build/moz.configure/old.configure), we can just process it with sed
instead of autoconf.
Review commit: https://reviewboard.mozilla.org/r/45905/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/45905/
Updated•9 years ago
|
Attachment #8740684 -
Flags: review?(gps) → review+
Comment 3•9 years ago
|
||
Comment on attachment 8740684 [details]
MozReview Request: Bug 1264129 - Add verbosity for the shell and autoconf checks in moz.configure. r?gps
https://reviewboard.mozilla.org/r/45903/#review42471
Comment 4•9 years ago
|
||
Comment on attachment 8740685 [details]
MozReview Request: Bug 1264129 - Use sed to update configure from configure.in, instead of autoconf. r?gps
https://reviewboard.mozilla.org/r/45905/#review42475
Nice hack.
Always happy to r+ files that net remove lines from client.mk.
Attachment #8740685 -
Flags: review?(gps) → review+
Comment 7•9 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/4d1ff5526e6f
https://hg.mozilla.org/mozilla-central/rev/862f44c0c10c
https://hg.mozilla.org/mozilla-central/rev/b68333205a82
Status: NEW → RESOLVED
Closed: 9 years ago
status-firefox48:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla48
Updated•7 years ago
|
Product: Core → Firefox Build System
You need to log in
before you can comment on or make changes to this bug.
Description
•