1264129 - Misc pyconfigure cleanups

Status: RESOLVED FIXED

(Firefox Build System :: General, defect)

Comment 1

[Mike Hommey [:glandium]]

Attachment: MozReview Request: Bug 1264129 - Add verbosity for the shell and autoconf checks in moz.configure. r?gps

Also get an absolute path for the shell.

Review commit: https://reviewboard.mozilla.org/r/45903/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/45903/

Comment 2

[Mike Hommey [:glandium]]

Attachment: MozReview Request: Bug 1264129 - Use sed to update configure from configure.in, instead of autoconf. r?gps

The configure.in is a small wrapper around python configure, that is
still a m4 script so that people running autoconf manually can still
do so without breaking their stuff (and we have jobs that do that
on automation as well).

But considering how simple the m4 is, to avoid having the autoconf
checking code twice (once in client.mk and once in
build/moz.configure/old.configure), we can just process it with sed
instead of autoconf.

Review commit: https://reviewboard.mozilla.org/r/45905/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/45905/

Comment 3

[Gregory Szorc [:gps]]

Comment on attachment 8740684 [details]
MozReview Request: Bug 1264129 - Add verbosity for the shell and autoconf checks in moz.configure. r?gps

https://reviewboard.mozilla.org/r/45903/#review42471

Comment 4

[Gregory Szorc [:gps]]

Comment on attachment 8740685 [details]
MozReview Request: Bug 1264129 - Use sed to update configure from configure.in, instead of autoconf. r?gps

https://reviewboard.mozilla.org/r/45905/#review42475

Nice hack.

Always happy to r+ files that net remove lines from client.mk.

Comment 5

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/4d1ff5526e6f
https://hg.mozilla.org/integration/mozilla-inbound/rev/862f44c0c10c

Comment 6

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/b68333205a82

Comment 7

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/4d1ff5526e6f
https://hg.mozilla.org/mozilla-central/rev/862f44c0c10c
https://hg.mozilla.org/mozilla-central/rev/b68333205a82