Awesomebar popup incorrectly overlaps the navbar on Windows 10

RESOLVED FIXED in Firefox 48

Status

()

Firefox
Theme
RESOLVED FIXED
2 years ago
2 years ago

People

(Reporter: adw, Assigned: adw)

Tracking

(Blocks: 1 bug)

Trunk
Firefox 48
Unspecified
Windows 10
Points:
---

Firefox Tracking Flags

(firefox48 fixed)

Details

MozReview Requests

()

Submitter Diff Changes Open Issues Last Updated
Loading...
Error loading review requests:

Attachments

(2 attachments)

The popup's y position is calculated like this:

  let yOffset =
    document.getElementById("nav-bar").getBoundingClientRect().bottom -
    aInput.getBoundingClientRect().bottom;

Which was supposed to be a cross-platform way to properly position the popup so that its top edge touches the navbar's bottom edge (as opposed to having margin-top per platform/theme), but that's clearly wrong for Windows 10.

It was also wrong for Linux, which is why I added 1px of margin-top: http://mxr.mozilla.org/mozilla-central/source/browser/themes/linux/browser.css#1108

I'll try to find a better way of calculating the offset that works everywhere.  If that's not possible then let's just add some margin-top on Windows 10.
(In reply to Drew Willcoxon :adw from comment #0)
> Which was supposed to be a cross-platform way to properly position the popup
> so that its top edge touches the navbar's bottom edge (as opposed to having
> margin-top per platform/theme), but that's clearly wrong for Windows 10.

Nightly looks good for me on Win 10.
Created attachment 8740850 [details]
Screenshot (6).png

Is this not the expected outcome?
http://hg.mozilla.org/mozilla-central/annotate/fb921246e2d6/browser/themes/windows/browser.css#l1170
Component: Location Bar → Theme
OS: Unspecified → Windows 10
Created attachment 8741551 [details]
MozReview Request: Bug 1264131 - Make the awesomebar popup open just below the navbar on Windows 10. r?mak

Aha, that would be it.  Thanks Dão.

Marco, the top edge of the popup should touch the bottom edge of the navbar.  They shouldn't overlap.

Review commit: https://reviewboard.mozilla.org/r/46567/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/46567/
Attachment #8741551 - Flags: review?(mak77)

Updated

2 years ago
Attachment #8741551 - Flags: review?(mak77) → review+
https://hg.mozilla.org/integration/fx-team/rev/e595db332894

Comment 6

2 years ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/e595db332894
Status: ASSIGNED → RESOLVED
Last Resolved: 2 years ago
status-firefox48: affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 48
You need to log in before you can comment on or make changes to this bug.