Closed
Bug 1264131
Opened 8 years ago
Closed 8 years ago
Awesomebar popup incorrectly overlaps the navbar on Windows 10
Categories
(Firefox :: Theme, defect)
Tracking
()
RESOLVED
FIXED
Firefox 48
Tracking | Status | |
---|---|---|
firefox48 | --- | fixed |
People
(Reporter: adw, Assigned: adw)
References
Details
Attachments
(2 files)
The popup's y position is calculated like this: let yOffset = document.getElementById("nav-bar").getBoundingClientRect().bottom - aInput.getBoundingClientRect().bottom; Which was supposed to be a cross-platform way to properly position the popup so that its top edge touches the navbar's bottom edge (as opposed to having margin-top per platform/theme), but that's clearly wrong for Windows 10. It was also wrong for Linux, which is why I added 1px of margin-top: http://mxr.mozilla.org/mozilla-central/source/browser/themes/linux/browser.css#1108 I'll try to find a better way of calculating the offset that works everywhere. If that's not possible then let's just add some margin-top on Windows 10.
Comment 1•8 years ago
|
||
(In reply to Drew Willcoxon :adw from comment #0) > Which was supposed to be a cross-platform way to properly position the popup > so that its top edge touches the navbar's bottom edge (as opposed to having > margin-top per platform/theme), but that's clearly wrong for Windows 10. Nightly looks good for me on Win 10.
Comment 2•8 years ago
|
||
Is this not the expected outcome?
Comment 3•8 years ago
|
||
http://hg.mozilla.org/mozilla-central/annotate/fb921246e2d6/browser/themes/windows/browser.css#l1170
Component: Location Bar → Theme
OS: Unspecified → Windows 10
Assignee | ||
Comment 4•8 years ago
|
||
Aha, that would be it. Thanks Dão. Marco, the top edge of the popup should touch the bottom edge of the navbar. They shouldn't overlap. Review commit: https://reviewboard.mozilla.org/r/46567/diff/#index_header See other reviews: https://reviewboard.mozilla.org/r/46567/
Attachment #8741551 -
Flags: review?(mak77)
Updated•8 years ago
|
Attachment #8741551 -
Flags: review?(mak77) → review+
Assignee | ||
Comment 5•8 years ago
|
||
https://hg.mozilla.org/integration/fx-team/rev/e595db332894
Comment 6•8 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/e595db332894
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 48
You need to log in
before you can comment on or make changes to this bug.
Description
•