1264154 - Debugging Fennec on Mac is busted

Status: RESOLVED FIXED

Description

[James Willcox (:snorp) ([e-mail])]

It tries to run lldb instead of jimdb

Comment 1

[James Willcox (:snorp) ([e-mail])]

Created attachment 8740736 [details] [diff] [review]
Always use gdb for debugging Fennec

Comment 2

[Geoff Brown [:gbrown]]

Comment on attachment 8740736 [details] [diff] [review]
Always use gdb for debugging Fennec

Review of attachment 8740736 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks. I wish I had a Mac so I could catch these things.

::: python/mozbuild/mozbuild/mach_commands.py
@@ +1174,5 @@
>  
>          if debug or debugger or debugparams:
>              import mozdebug
> +            if conditions.is_android(self):
> +                debugger = 'gdb'

This is a little "extreme", but probably okay. I'm a little concerned that someone will try to use the --debugger argument for something reasonable (point to their own gdb?) and will be puzzled that it doesn't have any affect, but trying to support --debugger on Android may just be a foot-gun.

Comment 3

[Ted Mielczarek [:ted] [:ted.mielczarek]]

This seems like it'd be a better fit inside `get_default_debugger_name`, which would actually fix it for all the consumers of mozdebug (the test harnesses, etc).

Comment 4

[James Willcox (:snorp) ([e-mail])]

(In reply to Ted Mielczarek [:ted.mielczarek] from comment #3)
> This seems like it'd be a better fit inside `get_default_debugger_name`,
> which would actually fix it for all the consumers of mozdebug (the test
> harnesses, etc).

It does make more sense there, but AFAICT there is no way to figure out that we're building for Android there.

Comment 5

[Ted Mielczarek [:ted] [:ted.mielczarek]]

I looked at this a bit, and I think there's a straightforward fix. `get_default_debugger_name` is using `mozinfo.os` right now:
https://dxr.mozilla.org/mozilla-central/rev/ae7413abfa4d3954a6a4ce7c1613a7100f367f9a/testing/mozbase/mozdebug/mozdebug/mozdebug.py#177

If we change that to first call `mozinfo.find_and_update_from_json()` and then instead use `mozinfo.info['os']`, it will return "android" for android builds, and then this will actually just work the way it's intended to work:
https://dxr.mozilla.org/mozilla-central/rev/ae7413abfa4d3954a6a4ce7c1613a7100f367f9a/testing/mozbase/mozdebug/mozdebug/mozdebug.py#66

Comment 6

[James Willcox (:snorp) ([e-mail])]

Created attachment 8746034 [details] [diff] [review]
Fix Fennec debugging on Mac

Comment 7

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/6fb68d7db94d

Comment 8

[Wes Kocher (:KWierso)]

https://hg.mozilla.org/mozilla-central/rev/6fb68d7db94d