Closed
Bug 1264154
Opened 9 years ago
Closed 9 years ago
Debugging Fennec on Mac is busted
Categories
(Firefox Build System :: General, defect)
Firefox Build System
General
Tracking
(firefox49 fixed)
RESOLVED
FIXED
mozilla49
Tracking | Status | |
---|---|---|
firefox49 | --- | fixed |
People
(Reporter: snorp, Unassigned)
Details
Attachments
(1 file, 1 obsolete file)
1.36 KB,
patch
|
ted
:
review+
|
Details | Diff | Splinter Review |
It tries to run lldb instead of jimdb
Reporter | ||
Comment 1•9 years ago
|
||
Attachment #8740736 -
Flags: review?(gbrown)
![]() |
||
Comment 2•9 years ago
|
||
Comment on attachment 8740736 [details] [diff] [review]
Always use gdb for debugging Fennec
Review of attachment 8740736 [details] [diff] [review]:
-----------------------------------------------------------------
Thanks. I wish I had a Mac so I could catch these things.
::: python/mozbuild/mozbuild/mach_commands.py
@@ +1174,5 @@
>
> if debug or debugger or debugparams:
> import mozdebug
> + if conditions.is_android(self):
> + debugger = 'gdb'
This is a little "extreme", but probably okay. I'm a little concerned that someone will try to use the --debugger argument for something reasonable (point to their own gdb?) and will be puzzled that it doesn't have any affect, but trying to support --debugger on Android may just be a foot-gun.
Attachment #8740736 -
Flags: review?(gbrown) → review+
Comment 3•9 years ago
|
||
This seems like it'd be a better fit inside `get_default_debugger_name`, which would actually fix it for all the consumers of mozdebug (the test harnesses, etc).
Updated•9 years ago
|
Component: mach → Build Config
Reporter | ||
Comment 4•9 years ago
|
||
(In reply to Ted Mielczarek [:ted.mielczarek] from comment #3)
> This seems like it'd be a better fit inside `get_default_debugger_name`,
> which would actually fix it for all the consumers of mozdebug (the test
> harnesses, etc).
It does make more sense there, but AFAICT there is no way to figure out that we're building for Android there.
Comment 5•9 years ago
|
||
I looked at this a bit, and I think there's a straightforward fix. `get_default_debugger_name` is using `mozinfo.os` right now:
https://dxr.mozilla.org/mozilla-central/rev/ae7413abfa4d3954a6a4ce7c1613a7100f367f9a/testing/mozbase/mozdebug/mozdebug/mozdebug.py#177
If we change that to first call `mozinfo.find_and_update_from_json()` and then instead use `mozinfo.info['os']`, it will return "android" for android builds, and then this will actually just work the way it's intended to work:
https://dxr.mozilla.org/mozilla-central/rev/ae7413abfa4d3954a6a4ce7c1613a7100f367f9a/testing/mozbase/mozdebug/mozdebug/mozdebug.py#66
Reporter | ||
Comment 6•9 years ago
|
||
Attachment #8746034 -
Flags: review?(ted)
Reporter | ||
Updated•9 years ago
|
Attachment #8740736 -
Attachment is obsolete: true
Updated•9 years ago
|
Attachment #8746034 -
Flags: review?(ted) → review+
Comment 8•9 years ago
|
||
bugherder |
Status: NEW → RESOLVED
Closed: 9 years ago
status-firefox49:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla49
Updated•7 years ago
|
Product: Core → Firefox Build System
You need to log in
before you can comment on or make changes to this bug.
Description
•