Closed
Bug 1264159
Opened 8 years ago
Closed 8 years ago
Use the new JS octal notation instead of parseInt when specifying octal numbers in browser code
Categories
(Firefox :: General, defect)
Firefox
General
Tracking
()
RESOLVED
FIXED
Firefox 48
Tracking | Status | |
---|---|---|
firefox48 | --- | fixed |
People
(Reporter: jwatt, Assigned: jwatt)
Details
Attachments
(1 file)
2.84 KB,
patch
|
standard8
:
review+
|
Details | Diff | Splinter Review |
Similar to bug 1263077 but for browser/. When "0" prefixed octal literals were deprecated back around 2010 we changed a bunch of code over to using parseInt("<octal-string>", 8); for example, see bug 572890. We've supported the new JS "0o" prefix for octal literals for a couple of years now though, and we should use that instead.
Assignee | ||
Comment 1•8 years ago
|
||
Attachment #8740757 -
Flags: review?(standard8)
Comment 2•8 years ago
|
||
Comment on attachment 8740757 [details] [diff] [review] patch Review of attachment 8740757 [details] [diff] [review]: ----------------------------------------------------------------- ::: browser/extensions/loop/chrome/content/shared/test/vendor/mocha.js @@ +12443,5 @@ > },{"_process":51,"child_process":41,"fs":41,"os":50,"path":41}],70:[function(require,module,exports){ > (function (process){ > var path = require('path'); > var fs = require('fs'); > +var _0777 = 0o777; Please don't change this file - its a test one that we import directly from mocha.js. I don't think we need to get it pushed upstream, as I suspect they're supporting older browsers still.
Attachment #8740757 -
Flags: review?(standard8) → review+
Comment 4•8 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/a5b52c5e3c96
Status: NEW → RESOLVED
Closed: 8 years ago
status-firefox48:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 48
You need to log in
before you can comment on or make changes to this bug.
Description
•