1264167 - [TV][Home] Renaming card under folder does not take effect immediately after inputing new name.

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::TV::Home, defect)

Description

[Fischer [:Fischer]]

STR:
1) Ping one app to Home
2) Add that pinged app to a folder
3) Rename that app under folder

Expected:
The card name changes after inputing new name

Actual:
The card name dose not change

Comment 1

[GitHub Autolander Bot]

Attachment: [gaia] Fischer-L:bug_1264167-rename-card-under-folder-issue > mozilla-b2g:master

Comment 2

[Fischer [:Fischer]]

Comment on attachment 8740798 [details] [review]
[gaia] Fischer-L:bug_1264167-rename-card-under-folder-issue > mozilla-b2g:master

@Rex,
When renaming card, cardManager and home do not handle the case of renaming card under folder.
As a result, renaming card under folder does not take effect immediately after inputing new name.
This patch check if card under folder is being renamed and do corresponding handling to fix the issue.
Thanks

Comment 3

[KM Lee [:rexboy] (inactivate after Sep. 22)]

Comment on attachment 8740798 [details] [review]
[gaia] Fischer-L:bug_1264167-rename-card-under-folder-issue > mozilla-b2g:master

We should have a way that works more consistently with other parts of the code. Please see my comments.

Comment 4

[Fischer [:Fischer]]

Comment on attachment 8740798 [details] [review]
[gaia] Fischer-L:bug_1264167-rename-card-under-folder-issue > mozilla-b2g:master

@Rex,
Modify to utilize Folder-type card's card-updated event to update new name, like the use of card-removed and card-inserted event, thanks.

Comment 5

[KM Lee [:rexboy] (inactivate after Sep. 22)]

Comment on attachment 8740798 [details] [review]
[gaia] Fischer-L:bug_1264167-rename-card-under-folder-issue > mozilla-b2g:master

Looks good to me. Thanks!

Comment 6

[Fischer [:Fischer]]

Land to Master: https://github.com/mozilla-b2g/gaia/commit/cf668bd3b1bb6b69d07f8b40af02cbf172f100a9