Enable libav assertions

RESOLVED FIXED in Firefox 48

Status

()

Core
Audio/Video: Playback
RESOLVED FIXED
2 years ago
2 years ago

People

(Reporter: cpeterson, Assigned: cpeterson)

Tracking

unspecified
mozilla48
Points:
---

Firefox Tracking Flags

(firefox46 wontfix, firefox47 affected, firefox48 fixed)

Details

Attachments

(1 attachment)

(Assignee)

Description

2 years ago
Created attachment 8740811 [details] [diff] [review]
enable-libav-assertions.patch

libav defines three assertion levels:

- assert0 are always enabled.
- assert1 are fast assertions that "can be enabled without fearing speedloss."
- assert2 are slow assertions in speed critical code.

https://mxr.mozilla.org/mozilla-central/source/media/libav/libavutil/avassert.h

This patch enables all assertions in debug builds and assert1 assertions in opt builds of Nightly and Aurora. The RELEASE_BUILD macro is only #defined in Firefox Beta and Release channels.
Attachment #8740811 - Flags: review?(jyavenard)
Attachment #8740811 - Flags: review?(jyavenard) → review+

Comment 2

2 years ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/e475e587c448
Status: NEW → RESOLVED
Last Resolved: 2 years ago
status-firefox48: affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla48
You need to log in before you can comment on or make changes to this bug.