Closed Bug 1264208 Opened 3 years ago Closed 3 years ago

Enable libav assertions

Categories

(Core :: Audio/Video: Playback, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla48
Tracking Status
firefox46 --- wontfix
firefox47 --- affected
firefox48 --- fixed

People

(Reporter: cpeterson, Assigned: cpeterson)

Details

Attachments

(1 file)

libav defines three assertion levels:

- assert0 are always enabled.
- assert1 are fast assertions that "can be enabled without fearing speedloss."
- assert2 are slow assertions in speed critical code.

https://mxr.mozilla.org/mozilla-central/source/media/libav/libavutil/avassert.h

This patch enables all assertions in debug builds and assert1 assertions in opt builds of Nightly and Aurora. The RELEASE_BUILD macro is only #defined in Firefox Beta and Release channels.
Attachment #8740811 - Flags: review?(jyavenard)
Attachment #8740811 - Flags: review?(jyavenard) → review+
https://hg.mozilla.org/mozilla-central/rev/e475e587c448
Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla48
You need to log in before you can comment on or make changes to this bug.